mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-05 09:33:25 -08:00
Some checks are pending
CodeQL / Analyze (cpp) (push) Waiting to run
CodeQL / Analyze (actions) (push) Waiting to run
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 cover (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 26 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Desktop / Prune caches (push) Waiting to run
Build Docker / Servatrice (arm) (push) Waiting to run
Build Docker / Servatrice (x86) (push) Waiting to run
Build Docker / Publish multi-platform Servatrice image (push) Blocked by required conditions
* [Installer] Request quit for hidden Cockatrice instances and record holders in abort telemetry * [Installer] Fix compiler warnings in holder probe and installer quit handler * [VisualDeckStorage] Order the includes the way clang-format wants them * [Installer] Ask a hidden instance to close, then offer to end it once The previous attempt had the client answer a registered window message, which cannot work for the update it was reported on: the instance being replaced is a client from before that message exists, so it never answers, and the user is left with "Cockatrice is still running" exactly as reported. Every step that can free the files has to be the installer's, so the client side is reverted. The probe now posts WM_CLOSE to the instance's own window whether that window is on screen or only in the notification area: the request does not need a visible window, an instance in the tray is the one this update has no other way to reach, and the confirmation Cockatrice answers with is a window Qt shows itself, so it is painted - unlike one restored from outside. A visible window is brought forward first, and Qt's bookkeeping windows stay excluded, because a close to the notification-area one terminates the instance without its confirmation. A question of the instance's own no longer suppresses the close. Withholding it protected nobody: the installer asked the user to close a program it had never asked, and a current client refuses the close while its confirmation is pending anyway, leaving the question where it is. The launcher mode keeps the visible-only rule, because a launcher without a window has already answered its own close and the wait ends it after a grace instead of asking a user who is not there. The guard asked the same question until the user gave up: after the automatic close failed it offered to end the programs, then re-ran the probe and showed the same dialog word for word when the answer was No, which is how an abort was reported three times over. It now asks once - Yes ends the Cockatrice, Oracle and Servatrice programs the payload installs and says what that costs, No cancels - and what survives an end is named in the abort instead of being put to the user as the same question again. The uninstaller's guard and the recovery path after a failed purge follow the same shape. Kept: the abort telemetry that records the holders, the close result and the end result as event data. --------- Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
259 lines
12 KiB
C++
259 lines
12 KiB
C++
#include "close_holders.h"
|
|
#include "holder_line.h"
|
|
#include "restart_manager_holders.h"
|
|
|
|
#include <algorithm>
|
|
#include <cstdlib>
|
|
#include <string>
|
|
#include <vector>
|
|
#include <windows.h>
|
|
|
|
namespace
|
|
{
|
|
/// The installer sets this, the same variable the running-instance guard uses, instead
|
|
/// of passing the directory on the command line: a path with spaces, quotes or a
|
|
/// trailing backslash then never has to survive NSIS quoting or a command line.
|
|
constexpr wchar_t INSTALL_DIR_VARIABLE[] = L"COCKATRICE_GUARD_DIR";
|
|
|
|
/// The installer sets this to the process it waits on (/PID=), so the launcher mode reads
|
|
/// the same process id the wait does instead of one that has to survive NSIS quoting.
|
|
constexpr wchar_t LAUNCHER_PID_VARIABLE[] = L"COCKATRICE_LAUNCHER_PID";
|
|
|
|
/// How long the close mode waits for the instance it asked to exit before it reports the
|
|
/// process as still running. The installer measures the purge right after this call, so
|
|
/// the wait belongs here: it is the only place that holds a handle on the process whose
|
|
/// exit it is waiting for.
|
|
constexpr unsigned long CLOSE_WAIT_MILLISECONDS = 30000;
|
|
|
|
/// How long the end mode waits for what it terminated to be gone. TerminateProcess is
|
|
/// asynchronous, and the installer measures the purge right after this returns, so a process
|
|
/// that is still tearing down would otherwise be reported as a holder for one more round.
|
|
constexpr unsigned long END_WAIT_MILLISECONDS = 5000;
|
|
|
|
/// Exit codes the installer reads. "Something was found" is deliberately not 0, so an
|
|
/// answer of "nothing holds the files" stays distinguishable from a probe that failed.
|
|
/// In the close mode 1 means a close was actually sent and 0 that every holder was left
|
|
/// to the user, which is what the report line next to the code spells out. 3 is only for
|
|
/// a lookup that failed and named nobody: one that failed but still named a process
|
|
/// running from the directory is answered with that process. 4 is only the launcher mode:
|
|
/// the process the installer waits on has no window a user could answer, which is the one
|
|
/// answer the installer acts on by itself instead of asking the user.
|
|
enum ExitCode
|
|
{
|
|
EXIT_NO_HOLDERS = 0,
|
|
EXIT_HOLDERS_FOUND = 1,
|
|
EXIT_NOT_CONFIGURED = 2,
|
|
EXIT_PROBE_FAILED = 3,
|
|
EXIT_NO_WINDOW = 4,
|
|
};
|
|
|
|
/// The probe has four modes, selected by the first argument:
|
|
///
|
|
/// (none) name what holds the payload, one line, for the guard prompt and the
|
|
/// abort dialog/log
|
|
/// --close-holders bring the running Cockatrice forward, ask it to close, and wait for
|
|
/// it to exit, for the offer to close after a failed purge
|
|
/// --end-holders end the running Cockatrice, Oracle and Servatrice and wait for them to
|
|
/// be gone, for the last resort the guard prompt offers when a close did
|
|
/// not free the files
|
|
/// --close-launcher ask the one process the installer waits on (/PID=) to close and say
|
|
/// whether there was a window to ask at all, because an instance with
|
|
/// no window has answered its own close and is stuck in shutdown
|
|
///
|
|
/// The guard's three modes answer from two lookups that cover each other's blind spot: the
|
|
/// Restart Manager names whoever has a payload file open, and every process running from the
|
|
/// directory is named as well, because a running instance holds its own image and the modules
|
|
/// it loaded as mappings rather than open files and the Restart Manager does not always
|
|
/// report those. Neither lookup alone is the guard's authority: an instance the file
|
|
/// handles do not name is exactly the case that left a half-replaced install behind.
|
|
enum class Mode
|
|
{
|
|
Name, ///< name the holders
|
|
Close, ///< ask the holders to close
|
|
End, ///< end the holders
|
|
CloseLauncher, ///< ask the one process the installer waits on to close
|
|
};
|
|
|
|
Mode requestedMode(int argumentCount, char **arguments)
|
|
{
|
|
if (argumentCount > 1) {
|
|
const std::string mode(arguments[1]);
|
|
if (mode == "--close-holders") {
|
|
return Mode::Close;
|
|
}
|
|
if (mode == "--end-holders") {
|
|
return Mode::End;
|
|
}
|
|
if (mode == "--close-launcher") {
|
|
return Mode::CloseLauncher;
|
|
}
|
|
}
|
|
return Mode::Name;
|
|
}
|
|
|
|
/// Writes one line to the pipe nsExec reads. Narrowed to ASCII on purpose: the bytes
|
|
/// come back to the installer as an ANSI string, so a non-ASCII process name would be
|
|
/// mojibake in the log; a '?' at least stays honest. Control characters are dropped
|
|
/// too, so a name can never forge a second log line.
|
|
void writeLine(const std::wstring &text)
|
|
{
|
|
std::string narrow;
|
|
narrow.reserve(text.size() + 2);
|
|
for (const wchar_t character : text) {
|
|
narrow.push_back(character >= 0x20 && character < 0x7F ? static_cast<char>(character) : '?');
|
|
}
|
|
narrow += "\r\n";
|
|
DWORD written = 0;
|
|
WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), narrow.data(), static_cast<DWORD>(narrow.size()), &written, nullptr);
|
|
}
|
|
|
|
std::wstring environmentVariable(const wchar_t *name)
|
|
{
|
|
for (DWORD size = MAX_PATH; size <= 32768U; size *= 2) {
|
|
std::vector<wchar_t> buffer(size);
|
|
const DWORD length = GetEnvironmentVariableW(name, buffer.data(), size);
|
|
if (length == 0) {
|
|
return {};
|
|
}
|
|
if (length < size) {
|
|
return std::wstring(buffer.data(), length);
|
|
}
|
|
}
|
|
return {};
|
|
}
|
|
|
|
std::wstring installDirFromEnvironment()
|
|
{
|
|
return environmentVariable(INSTALL_DIR_VARIABLE);
|
|
}
|
|
|
|
/// The process id the installer waits on, or false when it was not passed or is not a
|
|
/// number. A pid of 0 is refused because the installer never passes one.
|
|
bool launcherProcessIdFromEnvironment(unsigned long &processId)
|
|
{
|
|
const std::wstring text = environmentVariable(LAUNCHER_PID_VARIABLE);
|
|
if (text.empty()) {
|
|
return false;
|
|
}
|
|
wchar_t *end = nullptr;
|
|
const unsigned long parsed = std::wcstoul(text.c_str(), &end, 10);
|
|
if (parsed == 0 || end == nullptr || *end != L'\0') {
|
|
return false;
|
|
}
|
|
processId = parsed;
|
|
return true;
|
|
}
|
|
|
|
/// Asks the one process the installer waits on to close and answers what it could do.
|
|
///
|
|
/// The guard closes a set and reports every holder; here there is exactly one process, and
|
|
/// the installer needs an answer it can act on rather than a sentence: a launcher with no
|
|
/// visible window has already answered its own close and is stuck in shutdown, so no answer
|
|
/// the installer offers would ever reach it. A window that was asked - including one the
|
|
/// instance is showing a question in - is still the user's decision.
|
|
int closeLauncher(const std::wstring &installDir)
|
|
{
|
|
unsigned long processId = 0;
|
|
if (!launcherProcessIdFromEnvironment(processId)) {
|
|
writeLine(L"the probe was not given the launcher process id");
|
|
return EXIT_NOT_CONFIGURED;
|
|
}
|
|
|
|
// Only an instance that still runs from the directory being replaced is asked: a bare
|
|
// process id names anything once it is reused, while a process running from the
|
|
// directory is the one the installer started this update from.
|
|
for (const Holder &holder : findProcessesRunningFrom(installDir)) {
|
|
if (holder.processId != processId) {
|
|
continue;
|
|
}
|
|
if (!isCockatriceImage(holder.imageName)) {
|
|
writeLine(L"the launcher is not cockatrice.exe, left to you");
|
|
return EXIT_PROBE_FAILED;
|
|
}
|
|
const CloseHoldersResult result = closeCockatriceHolders({holder}, CLOSE_WAIT_MILLISECONDS, false);
|
|
writeLine(result.report);
|
|
if (result.askedToClose > 0) {
|
|
return EXIT_HOLDERS_FOUND;
|
|
}
|
|
return result.withoutWindow > 0 ? EXIT_NO_WINDOW : EXIT_HOLDERS_FOUND;
|
|
}
|
|
// Not an answer: the lookup may have failed or refused the image, and the installer
|
|
// holds a live handle on that process, so "not found" must not read as "gone". The
|
|
// installer shows its dialog for this code instead of acting on it.
|
|
writeLine(L"the launcher is not running from the directory being replaced, left to you");
|
|
return EXIT_PROBE_FAILED;
|
|
}
|
|
} // namespace
|
|
|
|
int main(int argumentCount, char **arguments)
|
|
{
|
|
const std::wstring installDir = installDirFromEnvironment();
|
|
if (installDir.empty()) {
|
|
writeLine(L"the probe was not given the install directory");
|
|
return EXIT_NOT_CONFIGURED;
|
|
}
|
|
|
|
const Mode mode = requestedMode(argumentCount, arguments);
|
|
// The launcher mode answers about exactly one process, so the holder set below is what it
|
|
// does not need - and the Restart Manager call behind it is the slowest thing this tool
|
|
// does, which must not delay a wait that started with a ten-second grace.
|
|
if (mode == Mode::CloseLauncher) {
|
|
return closeLauncher(installDir);
|
|
}
|
|
|
|
// Processes running from the directory first: they are the instance the user is asked
|
|
// to close, and the Restart Manager may not name any of them (see
|
|
// findProcessesRunningFrom). The file holders follow, deduplicated by process, so an
|
|
// instance that both runs from the directory and holds a payload file is named once.
|
|
// Neither lookup may name the probe or the process that started it, whichever one found
|
|
// it: an installer or uninstaller running from the directory it is replacing would
|
|
// otherwise be named as a holder, and closing it is a request nobody can answer.
|
|
std::vector<Holder> holders = findProcessesRunningFrom(installDir);
|
|
const std::vector<unsigned long> asking = askingProcessIds();
|
|
std::vector<Holder> fileHolders;
|
|
const unsigned long error = findProcessesUsingFiles(collectPayloadFiles(installDir), fileHolders);
|
|
for (const Holder &holder : fileHolders) {
|
|
if (std::find(asking.begin(), asking.end(), holder.processId) != asking.end()) {
|
|
continue;
|
|
}
|
|
const bool alreadyNamed = std::any_of(holders.begin(), holders.end(), [&holder](const Holder &named) {
|
|
return named.processId == holder.processId;
|
|
});
|
|
if (!alreadyNamed) {
|
|
holders.push_back(holder);
|
|
}
|
|
}
|
|
|
|
// A failed lookup only makes the probe unable to answer when it also named nobody: with
|
|
// a process running from the directory the installer still knows what to close, and
|
|
// that is worth more to the guard than the code of the query that missed it.
|
|
if (error != ERROR_SUCCESS && holders.empty()) {
|
|
writeLine(L"the Restart Manager lookup failed with win32 error " + std::to_wstring(error));
|
|
return EXIT_PROBE_FAILED;
|
|
}
|
|
|
|
if (holders.empty()) {
|
|
// No output in the naming mode: the installer words the "nothing is holding them"
|
|
// case, and it owns the message either way. The acting modes say it themselves,
|
|
// because their line is logged verbatim next to what they were asked to do.
|
|
if (mode != Mode::Name) {
|
|
writeLine(L"nothing is holding the files");
|
|
}
|
|
return EXIT_NO_HOLDERS;
|
|
}
|
|
if (mode == Mode::Name) {
|
|
writeLine(formatHolders(holders));
|
|
return EXIT_HOLDERS_FOUND;
|
|
}
|
|
if (mode == Mode::End) {
|
|
const EndHoldersResult result = endHolders(holders, END_WAIT_MILLISECONDS);
|
|
writeLine(result.report);
|
|
return result.ended > 0 ? EXIT_HOLDERS_FOUND : EXIT_NO_HOLDERS;
|
|
}
|
|
|
|
// Hidden windows are asked to close here: an instance in the notification area is the one
|
|
// this update has no other way to reach, and the guard's end answer is behind that attempt.
|
|
const CloseHoldersResult result = closeCockatriceHolders(holders, CLOSE_WAIT_MILLISECONDS, true);
|
|
writeLine(result.report);
|
|
return result.askedToClose > 0 ? EXIT_HOLDERS_FOUND : EXIT_NO_HOLDERS;
|
|
}
|