mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 09:05:10 -07:00
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
* [Server/Client/Protocol] Reporting users + moderation queue functionality Took 6 minutes Took 3 minutes Took 8 seconds Took 11 minutes Took 12 minutes Took 7 minutes Took 15 seconds Took 2 minutes Took 1 minute Took 30 seconds Took 16 seconds * CI Fix Took 6 minutes * CI Fix Took 6 minutes * [Protocol] Add moderation investigation commands Adds the protocol layer for the moderation investigation suite: - Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017) - Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins - last_login on Response_ReportUserInfo and warning_il on Response_WarnList Took 2 minutes * [Utility] Add warning categories parser with infraction levels Parses the server's 'officialwarnings' setting (comma-separated, optional '|IL' suffix) into WarningCategory structs so the client can display the infraction level of each warning category. Includes GTest coverage. * [Server] Add moderation investigation tools Implements the server side of the moderation suite: - getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods - Handlers for all five new commands with audit records (PASSWORD_RESET, REMOVE_USER_AVATAR); password resets return a generated temporary password - cmdGetWarnList now reports per-category infraction levels from the officialwarnings setting; cmdReportUserInfo reports last_login - Update servatrice.ini.example with the warning taxonomy - Password/avatar mutations report RespNameNotFound when the user does not exist * [Client] Add moderation tab with investigate, password reset, and avatar removal - New Moderation tab: search a user to show account info, alternate accounts, login sessions, and staff last logins; actions to reset the user's password (shows the generated temporary password) and remove the user's avatar - 'Investigate user' entry in the user context menu opens the tab pre-loaded for that user - Warning dialog shows the infraction level of each warning category - Tab wired into TabSupervisor with a moderator-gated menu action, shortcut, and tabs.ini persistence (default closed) * [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes Security: - Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible) - Reject password reset on users with equal/higher privilege than caller - Notify affected user via Event_NotifyUser::CUSTOM when password is reset - Add server-side category whitelist for reports - Drop reporter name fallback in comment/details authorization (ID-only) - Force password change: new DB column + login enforcement + client disconnect Bugs: - XSS via QTextEdit::append() → insertPlainText() in report tab and utils - allNotified initialized to true even with empty recipients list - Warning combo box: use currentData() instead of baked-in display text - Report resolution now records who resolved (resolved_by column + audit) Performance: - IP-correlation subquery: add 6-month window + LIMIT 200 - getUserSessions: clamp limit to 500 Non-blocking: - Palette-aware colors in report_utils.cpp (dark/light mode) - Report list pagination: offset/limit fields + total_count in response - SessionCommand enum gap comment for reserved values 1201-1203 Schema: 36→37 (force_password_change), 37→38 (resolved_by) Took 12 minutes Took 16 seconds * Fix macOs pedantry Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
255 lines
7.6 KiB
C++
255 lines
7.6 KiB
C++
#ifndef SERVER_H
|
|
#define SERVER_H
|
|
|
|
#include "server_player_reference.h"
|
|
|
|
#include <QMultiMap>
|
|
#include <QMutex>
|
|
#include <QObject>
|
|
#include <QReadWriteLock>
|
|
#include <libcockatrice/protocol/pb/commands.pb.h>
|
|
#include <libcockatrice/protocol/pb/serverinfo_ban.pb.h>
|
|
#include <libcockatrice/protocol/pb/serverinfo_user.pb.h>
|
|
|
|
class Server_DatabaseInterface;
|
|
class Server_Game;
|
|
class Server_Room;
|
|
class Server_ProtocolHandler;
|
|
class Server_AbstractUserInterface;
|
|
class GameReplay;
|
|
class IslMessage;
|
|
class SessionEvent;
|
|
class RoomEvent;
|
|
class DeckList;
|
|
class ServerInfo_Game;
|
|
class ServerInfo_Room;
|
|
class Response;
|
|
class GameEventContainer;
|
|
class CommandContainer;
|
|
class Command_JoinGame;
|
|
|
|
enum AuthenticationResult
|
|
{
|
|
NotLoggedIn,
|
|
PasswordRight,
|
|
UnknownUser,
|
|
WouldOverwriteOldSession,
|
|
UserIsBanned,
|
|
UsernameInvalid,
|
|
RegistrationRequired,
|
|
UserIsInactive,
|
|
ClientIdRequired,
|
|
PasswordChangeRequired
|
|
};
|
|
|
|
class Server : public QObject
|
|
{
|
|
Q_OBJECT
|
|
signals:
|
|
void pingClockTimeout();
|
|
void sigSendIslMessage(const IslMessage &message, int serverId);
|
|
void endSession(qint64 sessionId);
|
|
private slots:
|
|
void broadcastRoomUpdate(const ServerInfo_Room &roomInfo, bool sendToIsl = false);
|
|
|
|
public:
|
|
mutable QReadWriteLock clientsLock, roomsLock; // locking order: roomsLock before clientsLock
|
|
explicit Server(QObject *parent = nullptr);
|
|
~Server() override = default;
|
|
AuthenticationResult loginUser(Server_ProtocolHandler *session,
|
|
QString &name,
|
|
const QString &password,
|
|
bool passwordNeedsHash,
|
|
QString &reason,
|
|
int &secondsLeft,
|
|
QString &clientid,
|
|
QString &clientVersion,
|
|
QString &connectionType);
|
|
void broadcastUserInfoUpdate(Server_ProtocolHandler *source);
|
|
|
|
const QMap<int, Server_Room *> &getRooms()
|
|
{
|
|
return rooms;
|
|
}
|
|
|
|
Server_AbstractUserInterface *findUser(const QString &userName) const;
|
|
const QMap<QString, Server_ProtocolHandler *> &getUsers() const
|
|
{
|
|
return users;
|
|
}
|
|
const QMap<qint64, Server_ProtocolHandler *> &getUsersBySessionId() const
|
|
{
|
|
return usersBySessionId;
|
|
}
|
|
virtual QMap<QString, bool> getServerRequiredFeatureList() const
|
|
{
|
|
return QMap<QString, bool>();
|
|
}
|
|
void addClient(Server_ProtocolHandler *player);
|
|
void removeClient(Server_ProtocolHandler *player);
|
|
QList<QString> getOnlineModeratorList() const;
|
|
virtual QString getLoginMessage() const
|
|
{
|
|
return QString();
|
|
}
|
|
virtual SessionEvent *getLoginSessionEvent() const
|
|
{
|
|
return nullptr;
|
|
}
|
|
virtual QString getRequiredFeatures() const
|
|
{
|
|
return QString();
|
|
}
|
|
virtual bool permitUnregisteredUsers() const
|
|
{
|
|
return true;
|
|
}
|
|
virtual bool getGameShouldPing() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getClientIDRequiredEnabled() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getRegOnlyServerEnabled() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getMaxUserLimitEnabled() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getEnableLogQuery() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getStoreReplaysEnabled() const
|
|
{
|
|
return true;
|
|
}
|
|
virtual int getIdleClientTimeout() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getClientKeepAlive() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxGameInactivityTime() const
|
|
{
|
|
return 9999999;
|
|
}
|
|
virtual int getMaxPlayerInactivityTime() const
|
|
{
|
|
return 9999999;
|
|
}
|
|
virtual int getMessageCountingInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxMessageCountPerInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxMessageSizePerInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxGamesPerUser() const
|
|
{
|
|
return -1;
|
|
}
|
|
virtual int getCommandCountingInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxCommandCountPerInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxUserTotal() const
|
|
{
|
|
return 9999999;
|
|
}
|
|
virtual int getServerID() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual bool permitCreateGameAsJudge() const
|
|
{
|
|
return false;
|
|
}
|
|
|
|
Server_DatabaseInterface *getDatabaseInterface() const;
|
|
int getNextLocalGameId()
|
|
{
|
|
QMutexLocker locker(&nextLocalGameIdMutex);
|
|
return ++nextLocalGameId;
|
|
}
|
|
|
|
void sendIsl_Response(const Response &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_SessionEvent(const SessionEvent &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_GameEventContainer(const GameEventContainer &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_RoomEvent(const RoomEvent &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_GameCommand(const CommandContainer &item, int serverId, qint64 sessionId, int roomId, int playerId);
|
|
void sendIsl_RoomCommand(const CommandContainer &item, int serverId, qint64 sessionId, int roomId);
|
|
|
|
const QMap<QString, Server_AbstractUserInterface *> &getExternalUsers() const
|
|
{
|
|
return externalUsers;
|
|
}
|
|
|
|
void addPersistentPlayer(const QString &userName, int roomId, int gameId, int playerId);
|
|
void removePersistentPlayer(const QString &userName, int roomId, int gameId, int playerId);
|
|
QList<PlayerReference> getPersistentPlayerReferences(const QString &userName) const;
|
|
int getUsersCount() const;
|
|
int getGamesCount() const;
|
|
int getTCPUserCount() const
|
|
{
|
|
return tcpUserCount;
|
|
}
|
|
int getWebSocketUserCount() const
|
|
{
|
|
return webSocketUserCount;
|
|
}
|
|
|
|
private:
|
|
QMultiMap<QString, PlayerReference> persistentPlayers;
|
|
mutable QReadWriteLock persistentPlayersLock;
|
|
int nextLocalGameId, tcpUserCount, webSocketUserCount;
|
|
QMutex nextLocalGameIdMutex;
|
|
|
|
protected slots:
|
|
void externalUserJoined(const ServerInfo_User &userInfo);
|
|
void externalUserLeft(const QString &userName);
|
|
void externalRoomUserJoined(int roomId, const ServerInfo_User &userInfo);
|
|
void externalRoomUserLeft(int roomId, const QString &userName);
|
|
void externalRoomSay(int roomId, const QString &userName, const QString &message);
|
|
void externalRoomRemoveMessages(int roomId, const QString &userName, int amount);
|
|
void externalRoomGameListChanged(int roomId, const ServerInfo_Game &gameInfo);
|
|
void
|
|
externalJoinGameCommandReceived(const Command_JoinGame &cmd, int cmdId, int roomId, int serverId, qint64 sessionId);
|
|
void
|
|
externalGameCommandContainerReceived(const CommandContainer &cont, int playerId, int serverId, qint64 sessionId);
|
|
void externalGameEventContainerReceived(const GameEventContainer &cont, qint64 sessionId);
|
|
void externalResponseReceived(const Response &resp, qint64 sessionId);
|
|
|
|
virtual void doSendIslMessage(const IslMessage & /* msg */, int /* serverId */)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
void prepareDestroy();
|
|
void setDatabaseInterface(Server_DatabaseInterface *_databaseInterface);
|
|
QList<Server_ProtocolHandler *> clients;
|
|
QMap<qint64, Server_ProtocolHandler *> usersBySessionId;
|
|
QMap<QString, Server_ProtocolHandler *> users;
|
|
QMap<qint64, Server_AbstractUserInterface *> externalUsersBySessionId;
|
|
QMap<QString, Server_AbstractUserInterface *> externalUsers;
|
|
QMap<int, Server_Room *> rooms;
|
|
QMap<QThread *, Server_DatabaseInterface *> databaseInterfaces;
|
|
void addRoom(Server_Room *newRoom);
|
|
};
|
|
|
|
#endif
|