mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-05 09:33:25 -08:00
315cbae345
The executables precompile Qt since #7235, but the libcockatrice_* static libraries still reparse the full Qt Core stack in every TU. Measured over the tree after the IWYU pass: 380 MB of header parse in the libraries, 92% of it reachable from qtcore_pch.h. - Apply qtcore_pch.h to the 14 Qt Core static library targets (skips libcockatrice_rng: its SFMT.c is C and cannot use a C++ precompiled header). - Grow qtcore_pch.h with 25 QtCore headers that IWYU shows are re-parsed across many TUs and were not already reachable from the existing list (JSON/QUuid cluster, QSettings, item models, threading, XmlStream, QTemporaryDir, ...). - Grow qtwidgets_pch.h with 30 QtGui/QtWidgets headers (dialog cluster, item views, QImageReader, ...). Only stable Qt headers go into the PCH, so it rarely invalidates. Test executables stay PCH-less: 1-3 TUs per target does not amortize the extra precompile. Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
28 lines
1.1 KiB
CMake
28 lines
1.1 KiB
CMake
# Top-level wrapper for the protobuf library
|
|
|
|
add_subdirectory(libcockatrice/protocol/pb)
|
|
|
|
add_library(libcockatrice_protocol STATIC)
|
|
|
|
set(SOURCES libcockatrice/protocol/debug_pb_message.cpp libcockatrice/protocol/featureset.cpp
|
|
libcockatrice/protocol/get_pb_extension.cpp libcockatrice/protocol/pending_command.cpp
|
|
)
|
|
|
|
set(HEADERS libcockatrice/protocol/debug_pb_message.h libcockatrice/protocol/featureset.h
|
|
libcockatrice/protocol/get_pb_extension.h libcockatrice/protocol/pending_command.h
|
|
)
|
|
|
|
target_sources(libcockatrice_protocol PRIVATE ${SOURCES} ${HEADERS})
|
|
|
|
add_dependencies(libcockatrice_protocol libcockatrice_protocol_pb)
|
|
|
|
# Link the actual generated protobuf library
|
|
target_link_libraries(libcockatrice_protocol PUBLIC ${QT_CORE_MODULE} libcockatrice_protocol_pb libcockatrice_utility)
|
|
|
|
# Expose include paths
|
|
target_include_directories(
|
|
libcockatrice_protocol PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}
|
|
${CMAKE_CURRENT_BINARY_DIR} # points to the generated headers
|
|
)
|
|
|
|
target_precompile_headers(libcockatrice_protocol PRIVATE "${CMAKE_SOURCE_DIR}/cmake/pch/qtcore_pch.h")
|