mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-27 08:24:39 -07:00
8ca749c07d
* [DeckShare] Open shared decks via links with a gated preview flow - Serialized url-chain dispatcher in IntentUrlParser; queue-drained urlChainFinished(bool) drives the startup auto-connect fallback - Open-shared-deck intent with sequential download state machine, 15s per-item timeout, partial-success offer, livable Cancel via ApplicationModal dlg_login_prompt interactive fallback - Preview dialog: download progress label, share vocab sweep, palette-highlight selection frame, Space/Enter keyboard toggle, NoFocus checkbox, double-click tile opens immediately - Confirm-before-server-migration with one-shot restore to the previous server on failed/cancelled chains (statusChanged settle deferral), hostname-only identity comparisons - Skip credential link when already connected; arrow-key navigation in FlowWidget; card glows use palette highlight - Address code-review M1-M4 and UI/UX QA blockers 1-2 * [DeckShare] End the open-shared-deck files with a trailing newline * [DeckShare] Forward a dependency's cancellation as the owner's own * [DeckShare] Let intent chains opt into the link sign-in dialog * [DeckShare] Track link-intent chains per-run so each can restore its own session * [Settings] Match a server on the exact host and port when adding it * [DeckShare] Confirm the share link's target server before opening a deck * [DeckShare] Reformat the link sign-in intent constructor * [DeckShare] Time the share-list round trip and backstop silently-destroyed intent chains * [Client] Drain a single-instance payload before its handlers read the socket again * [Client] Treat a busy single-instance primary as alive instead of stealing its socket * [DeckShare] Keep arrow-key navigation between flow items inside a scroll area * [Client] Skip the startup connection when a macOS URL launch owns the connection * [Client] Redact share secrets from activation URL logs * [Client] Make the link-connection gates port-aware and keyboard-safe Second-pass review notes for the shared-deck link flow (Cockatrice#7244): - FlowWidget arrow-key navigation is opt-in via addNavigableWidget, so combo/spin controls on the analytics flows keep their own arrow keys - isConnectedTo and the open-deck/join-game preconditions compare the configured server port alongside the host, so a same-host/different-port link cannot resolve its share token or game id on the wrong instance - the link sign-in dialog reuses an existing server entry's saved name instead of renaming it to the raw hostname - skipStartupAutoConnect is cleared once the launch chain connects, so a later mid-session declined link cannot fire the startup fallback - the plain-launch path of SingleInstanceManager no longer blocks on the primary's ACK - link- and server-supplied text is html-escaped in the confirm prompts and shared-deck preview so markup cannot spoof the shown messages --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
68 lines
No EOL
2 KiB
C++
68 lines
No EOL
2 KiB
C++
#ifndef COCKATRICE_DLG_SHARED_DECKS_PREVIEW_H
|
|
#define COCKATRICE_DLG_SHARED_DECKS_PREVIEW_H
|
|
|
|
#include <QDialog>
|
|
#include <QList>
|
|
|
|
class FlowWidget;
|
|
class QCloseEvent;
|
|
class QLabel;
|
|
class QPushButton;
|
|
class ServerInfo_DeckShareItem;
|
|
class SharedDeckPreviewWidget;
|
|
class CardDatabaseQuerier;
|
|
|
|
/**
|
|
* @brief Non-modal preview of the decks contained in a shared-deck link.
|
|
*
|
|
* Lets the user pick which of the shared decks to open before anything is
|
|
* downloaded. Emits openRequested with the ids of the chosen decks, or
|
|
* cancelled when the user closes the dialog without choosing. Once the user
|
|
* picks, the dialog switches into a "downloading" state: the tiles and open
|
|
* buttons are disabled, a progress label shows the current download and Cancel
|
|
* stays functional so the download can be aborted.
|
|
*/
|
|
class DlgSharedDecksPreview : public QDialog
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit DlgSharedDecksPreview(QWidget *parent,
|
|
const CardDatabaseQuerier *querier,
|
|
const QString &shareName,
|
|
qint64 expiresAt,
|
|
const QString &serverText,
|
|
const QList<ServerInfo_DeckShareItem> &items);
|
|
|
|
void setDownloadProgress(int done, int total, const QString ¤tDeckName);
|
|
|
|
public slots:
|
|
void setDownloading(bool downloading);
|
|
|
|
signals:
|
|
void openRequested(const QList<int> &itemIds);
|
|
void cancelled();
|
|
|
|
protected:
|
|
void closeEvent(QCloseEvent *event) override;
|
|
|
|
private slots:
|
|
void openSelected();
|
|
void openAll();
|
|
void updateOpenSelectedEnabled();
|
|
void onCancel();
|
|
|
|
private:
|
|
QList<int> selectedItemIds() const;
|
|
|
|
FlowWidget *flowWidget;
|
|
QList<SharedDeckPreviewWidget *> tiles;
|
|
QList<int> itemIds;
|
|
QPushButton *openSelectedButton;
|
|
QPushButton *openAllButton;
|
|
QLabel *downloadStatusLabel;
|
|
bool resultEmitted = false;
|
|
bool downloadInProgress = false;
|
|
};
|
|
|
|
#endif // COCKATRICE_DLG_SHARED_DECKS_PREVIEW_H
|