mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 09:05:10 -07:00
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
* [Server/Client/Protocol] Reporting users + moderation queue functionality Took 6 minutes Took 3 minutes Took 8 seconds Took 11 minutes Took 12 minutes Took 7 minutes Took 15 seconds Took 2 minutes Took 1 minute Took 30 seconds Took 16 seconds * CI Fix Took 6 minutes * CI Fix Took 6 minutes * [Protocol] Add moderation investigation commands Adds the protocol layer for the moderation investigation suite: - Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017) - Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins - last_login on Response_ReportUserInfo and warning_il on Response_WarnList Took 2 minutes * [Utility] Add warning categories parser with infraction levels Parses the server's 'officialwarnings' setting (comma-separated, optional '|IL' suffix) into WarningCategory structs so the client can display the infraction level of each warning category. Includes GTest coverage. * [Server] Add moderation investigation tools Implements the server side of the moderation suite: - getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods - Handlers for all five new commands with audit records (PASSWORD_RESET, REMOVE_USER_AVATAR); password resets return a generated temporary password - cmdGetWarnList now reports per-category infraction levels from the officialwarnings setting; cmdReportUserInfo reports last_login - Update servatrice.ini.example with the warning taxonomy - Password/avatar mutations report RespNameNotFound when the user does not exist * [Client] Add moderation tab with investigate, password reset, and avatar removal - New Moderation tab: search a user to show account info, alternate accounts, login sessions, and staff last logins; actions to reset the user's password (shows the generated temporary password) and remove the user's avatar - 'Investigate user' entry in the user context menu opens the tab pre-loaded for that user - Warning dialog shows the infraction level of each warning category - Tab wired into TabSupervisor with a moderator-gated menu action, shortcut, and tabs.ini persistence (default closed) * [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes Security: - Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible) - Reject password reset on users with equal/higher privilege than caller - Notify affected user via Event_NotifyUser::CUSTOM when password is reset - Add server-side category whitelist for reports - Drop reporter name fallback in comment/details authorization (ID-only) - Force password change: new DB column + login enforcement + client disconnect Bugs: - XSS via QTextEdit::append() → insertPlainText() in report tab and utils - allNotified initialized to true even with empty recipients list - Warning combo box: use currentData() instead of baked-in display text - Report resolution now records who resolved (resolved_by column + audit) Performance: - IP-correlation subquery: add 6-month window + LIMIT 200 - getUserSessions: clamp limit to 500 Non-blocking: - Palette-aware colors in report_utils.cpp (dark/light mode) - Report list pagination: offset/limit fields + total_count in response - SessionCommand enum gap comment for reserved values 1201-1203 Schema: 36→37 (force_password_change), 37→38 (resolved_by) Took 12 minutes Took 16 seconds * Fix macOs pedantry Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
256 lines
8.8 KiB
C++
256 lines
8.8 KiB
C++
#include "tab_account.h"
|
|
|
|
#include "../client/sound_engine.h"
|
|
#include "../interface/widgets/dialogs/dlg_my_reports.h"
|
|
#include "../interface/widgets/server/user/user_info_box.h"
|
|
#include "../interface/widgets/server/user/user_list_manager.h"
|
|
#include "../interface/widgets/server/user/user_list_widget.h"
|
|
#include "../interface/widgets/utility/custom_line_edit.h"
|
|
#include "tab_supervisor.h"
|
|
|
|
#include <QPushButton>
|
|
#include <QVBoxLayout>
|
|
#include <libcockatrice/network/client/abstract/abstract_client.h>
|
|
#include <libcockatrice/protocol/pb/event_add_to_list.pb.h>
|
|
#include <libcockatrice/protocol/pb/event_remove_from_list.pb.h>
|
|
#include <libcockatrice/protocol/pb/event_user_joined.pb.h>
|
|
#include <libcockatrice/protocol/pb/event_user_left.pb.h>
|
|
#include <libcockatrice/protocol/pb/response_list_users.pb.h>
|
|
#include <libcockatrice/protocol/pb/session_commands.pb.h>
|
|
#include <libcockatrice/protocol/pending_command.h>
|
|
#include <libcockatrice/utility/string_limits.h>
|
|
|
|
TabAccount::TabAccount(TabSupervisor *_tabSupervisor, AbstractClient *_client, const ServerInfo_User &userInfo)
|
|
: Tab(_tabSupervisor), client(_client)
|
|
{
|
|
allUsersList = new UserListWidget(_tabSupervisor, client, UserListWidget::AllUsersList);
|
|
buddyList = new UserListWidget(_tabSupervisor, client, UserListWidget::BuddyList);
|
|
ignoreList = new UserListWidget(_tabSupervisor, client, UserListWidget::IgnoreList);
|
|
userInfoBox = new UserInfoBox(client, true);
|
|
userInfoBox->updateInfo(userInfo);
|
|
|
|
connect(allUsersList, &UserListWidget::openMessageDialog, this, &TabAccount::openMessageDialog);
|
|
connect(buddyList, &UserListWidget::openMessageDialog, this, &TabAccount::openMessageDialog);
|
|
connect(ignoreList, &UserListWidget::openMessageDialog, this, &TabAccount::openMessageDialog);
|
|
|
|
connect(client, &AbstractClient::userJoinedEventReceived, this, &TabAccount::processUserJoinedEvent);
|
|
connect(client, &AbstractClient::userLeftEventReceived, this, &TabAccount::processUserLeftEvent);
|
|
connect(client, &AbstractClient::buddyListReceived, this, &TabAccount::buddyListReceived);
|
|
connect(client, &AbstractClient::ignoreListReceived, this, &TabAccount::ignoreListReceived);
|
|
connect(client, &AbstractClient::addToListEventReceived, this, &TabAccount::processAddToListEvent);
|
|
connect(client, &AbstractClient::removeFromListEventReceived, this, &TabAccount::processRemoveFromListEvent);
|
|
|
|
// Attempt to populate the tab with the cache
|
|
buddyListReceived(tabSupervisor->getUserListManager()->getBuddyList().values());
|
|
ignoreListReceived(tabSupervisor->getUserListManager()->getIgnoreList().values());
|
|
|
|
PendingCommand *pend = AbstractClient::prepareSessionCommand(Command_ListUsers());
|
|
connect(pend, &PendingCommand::finished, this, &TabAccount::processListUsersResponse);
|
|
client->sendCommand(pend);
|
|
|
|
auto *vbox = new QVBoxLayout;
|
|
vbox->addWidget(userInfoBox);
|
|
|
|
myReportsButton = new QPushButton(tr("My Reports"));
|
|
connect(myReportsButton, &QPushButton::clicked, this, &TabAccount::openMyReports);
|
|
vbox->addWidget(myReportsButton);
|
|
|
|
vbox->addWidget(allUsersList);
|
|
|
|
auto *addToBuddyList = new QHBoxLayout;
|
|
addBuddyEdit = new LineEditUnfocusable;
|
|
addBuddyEdit->setMaxLength(MAX_NAME_LENGTH);
|
|
addBuddyEdit->setPlaceholderText(tr("Add to Buddy List"));
|
|
connect(addBuddyEdit, &LineEditUnfocusable::returnPressed, this, &TabAccount::addToBuddyList);
|
|
auto *addBuddyButton = new QPushButton("Add");
|
|
connect(addBuddyButton, &QPushButton::clicked, this, &TabAccount::addToBuddyList);
|
|
addToBuddyList->addWidget(addBuddyEdit);
|
|
addToBuddyList->addWidget(addBuddyButton);
|
|
|
|
auto *addToIgnoreList = new QHBoxLayout;
|
|
addIgnoreEdit = new LineEditUnfocusable;
|
|
addIgnoreEdit->setMaxLength(MAX_NAME_LENGTH);
|
|
addIgnoreEdit->setPlaceholderText(tr("Add to Ignore List"));
|
|
connect(addIgnoreEdit, &LineEditUnfocusable::returnPressed, this, &TabAccount::addToIgnoreList);
|
|
auto *addIgnoreButton = new QPushButton("Add");
|
|
connect(addIgnoreButton, &QPushButton::clicked, this, &TabAccount::addToIgnoreList);
|
|
addToIgnoreList->addWidget(addIgnoreEdit);
|
|
addToIgnoreList->addWidget(addIgnoreButton);
|
|
|
|
auto *buddyPanel = new QVBoxLayout;
|
|
buddyPanel->addWidget(buddyList);
|
|
buddyPanel->addLayout(addToBuddyList);
|
|
|
|
auto *ignorePanel = new QVBoxLayout;
|
|
ignorePanel->addWidget(ignoreList);
|
|
ignorePanel->addLayout(addToIgnoreList);
|
|
|
|
auto *mainLayout = new QHBoxLayout;
|
|
mainLayout->addLayout(buddyPanel);
|
|
mainLayout->addLayout(ignorePanel);
|
|
mainLayout->addLayout(vbox);
|
|
|
|
retranslateUi();
|
|
|
|
auto *mainWidget = new QWidget(this);
|
|
mainWidget->setLayout(mainLayout);
|
|
setCentralWidget(mainWidget);
|
|
}
|
|
|
|
void TabAccount::addToBuddyList()
|
|
{
|
|
const QString &userName = addBuddyEdit->text();
|
|
if (userName.isEmpty()) {
|
|
return;
|
|
}
|
|
|
|
const std::string listName = "buddy";
|
|
addToList(listName, userName);
|
|
addBuddyEdit->clear();
|
|
}
|
|
|
|
void TabAccount::addToIgnoreList()
|
|
{
|
|
const QString &userName = addIgnoreEdit->text();
|
|
if (userName.isEmpty()) {
|
|
return;
|
|
}
|
|
|
|
const std::string listName = "ignore";
|
|
addToList(listName, userName);
|
|
addIgnoreEdit->clear();
|
|
}
|
|
|
|
void TabAccount::addToList(const std::string &listName, const QString &userName)
|
|
{
|
|
Command_AddToList cmd;
|
|
cmd.set_list(listName);
|
|
cmd.set_user_name(userName.toStdString());
|
|
|
|
client->sendCommand(AbstractClient::prepareSessionCommand(cmd));
|
|
}
|
|
|
|
void TabAccount::retranslateUi()
|
|
{
|
|
myReportsButton->setText(tr("My Reports"));
|
|
allUsersList->retranslateUi();
|
|
buddyList->retranslateUi();
|
|
ignoreList->retranslateUi();
|
|
userInfoBox->retranslateUi();
|
|
}
|
|
|
|
void TabAccount::processListUsersResponse(const Response &response)
|
|
{
|
|
const Response_ListUsers &resp = response.GetExtension(Response_ListUsers::ext);
|
|
allUsersList->beginBulkLoad();
|
|
for (int i = 0; i < resp.user_list_size(); ++i) {
|
|
const ServerInfo_User &info = resp.user_list(i);
|
|
const QString &userName = QString::fromStdString(info.name());
|
|
allUsersList->processUserInfo(info, true);
|
|
ignoreList->setUserOnline(userName, true);
|
|
buddyList->setUserOnline(userName, true);
|
|
}
|
|
allUsersList->endBulkLoad();
|
|
|
|
ignoreList->sortItems();
|
|
buddyList->sortItems();
|
|
}
|
|
|
|
void TabAccount::processUserJoinedEvent(const Event_UserJoined &event)
|
|
{
|
|
const ServerInfo_User &info = event.user_info();
|
|
const QString &userName = QString::fromStdString(info.name());
|
|
|
|
allUsersList->processUserInfo(info, true);
|
|
ignoreList->setUserOnline(userName, true);
|
|
buddyList->setUserOnline(userName, true);
|
|
|
|
allUsersList->sortItems();
|
|
ignoreList->sortItems();
|
|
buddyList->sortItems();
|
|
|
|
if (buddyList->getUsers().keys().contains(userName)) {
|
|
soundEngine->playSound("buddy_join");
|
|
}
|
|
|
|
emit userJoined(info);
|
|
}
|
|
|
|
void TabAccount::processUserLeftEvent(const Event_UserLeft &event)
|
|
{
|
|
const QString &userName = QString::fromStdString(event.name());
|
|
|
|
if (buddyList->getUsers().keys().contains(userName)) {
|
|
soundEngine->playSound("buddy_leave");
|
|
}
|
|
|
|
if (allUsersList->deleteUser(userName)) {
|
|
ignoreList->setUserOnline(userName, false);
|
|
buddyList->setUserOnline(userName, false);
|
|
ignoreList->sortItems();
|
|
buddyList->sortItems();
|
|
|
|
emit userLeft(userName);
|
|
}
|
|
}
|
|
|
|
void TabAccount::buddyListReceived(const QList<ServerInfo_User> &_buddyList)
|
|
{
|
|
buddyList->beginBulkLoad();
|
|
for (const auto &user : _buddyList) {
|
|
buddyList->processUserInfo(user, false);
|
|
}
|
|
buddyList->endBulkLoad();
|
|
}
|
|
|
|
void TabAccount::ignoreListReceived(const QList<ServerInfo_User> &_ignoreList)
|
|
{
|
|
ignoreList->beginBulkLoad();
|
|
for (const auto &user : _ignoreList) {
|
|
ignoreList->processUserInfo(user, false);
|
|
}
|
|
ignoreList->endBulkLoad();
|
|
}
|
|
|
|
void TabAccount::processAddToListEvent(const Event_AddToList &event)
|
|
{
|
|
const ServerInfo_User &info = event.user_info();
|
|
const bool online = allUsersList->getUsers().contains(QString::fromStdString(info.name()));
|
|
const QString &list = QString::fromStdString(event.list_name());
|
|
|
|
UserListWidget *userList;
|
|
if (list == "buddy") {
|
|
userList = buddyList;
|
|
} else if (list == "ignore") {
|
|
userList = ignoreList;
|
|
} else {
|
|
return;
|
|
}
|
|
|
|
userList->processUserInfo(info, online);
|
|
userList->sortItems();
|
|
}
|
|
|
|
void TabAccount::processRemoveFromListEvent(const Event_RemoveFromList &event)
|
|
{
|
|
const auto &list = QString::fromStdString(event.list_name());
|
|
const auto &user = QString::fromStdString(event.user_name());
|
|
|
|
UserListWidget *userList;
|
|
if (list == "buddy") {
|
|
userList = buddyList;
|
|
} else if (list == "ignore") {
|
|
userList = ignoreList;
|
|
} else {
|
|
return;
|
|
}
|
|
|
|
userList->deleteUser(user);
|
|
}
|
|
|
|
void TabAccount::openMyReports()
|
|
{
|
|
auto *dlg = new DlgMyReports(client, this);
|
|
dlg->setAttribute(Qt::WA_DeleteOnClose);
|
|
dlg->exec();
|
|
}
|