Cockatrice/servatrice/migrations/servatrice_0035_to_0036.sql
Lukas Brübach f7998deb7a [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes
Security:
- Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible)
- Reject password reset on users with equal/higher privilege than caller
- Notify affected user via Event_NotifyUser::CUSTOM when password is reset
- Add server-side category whitelist for reports
- Drop reporter name fallback in comment/details authorization (ID-only)
- Force password change: new DB column + login enforcement + client disconnect

Bugs:
- XSS via QTextEdit::append() → insertPlainText() in report tab and utils
- allNotified initialized to true even with empty recipients list
- Warning combo box: use currentData() instead of baked-in display text
- Report resolution now records who resolved (resolved_by column + audit)

Performance:
- IP-correlation subquery: add 6-month window + LIMIT 200
- getUserSessions: clamp limit to 500

Non-blocking:
- Palette-aware colors in report_utils.cpp (dark/light mode)
- Report list pagination: offset/limit fields + total_count in response
- SessionCommand enum gap comment for reserved values 1201-1203

Schema: 36→37 (force_password_change), 37→38 (resolved_by)

Took 12 minutes


Took 16 seconds
2026-08-21 10:43:15 +02:00

53 lines
2.7 KiB
SQL

-- Servatrice db migration from version 35 to version 36
CREATE TABLE IF NOT EXISTS `cockatrice_reports` (
`id` int(11) unsigned NOT NULL AUTO_INCREMENT,
`reporter_id` int(7) unsigned NULL,
`reporter_name` varchar(35) NOT NULL,
`reported_user_id` int(7) unsigned NULL,
`reported_user_name` varchar(35) NOT NULL,
`game_id` int(7) unsigned NULL,
`room_id` int(7) unsigned NULL,
`category` varchar(255) NOT NULL,
`description` text NOT NULL,
`chat_log` mediumtext NULL,
`created_at` datetime NOT NULL,
`resolution_time` datetime NULL,
`status` enum('open','assigned','resolved','dismissed') NOT NULL DEFAULT 'open',
`assigned_to` int(7) unsigned NULL,
`resolved_by` int(7) unsigned NULL,
`resolution_note` text,
`notified` tinyint(1) NOT NULL DEFAULT 0,
PRIMARY KEY (`id`),
INDEX `idx_status` (`status`),
INDEX `idx_created` (`created_at`),
INDEX `idx_reporter_id_created` (`reporter_id`, `created_at`),
INDEX `idx_reported_user_name` (`reported_user_name`),
INDEX `idx_status_created` (`status`, `created_at`),
FOREIGN KEY (`reporter_id`) REFERENCES `cockatrice_users`(`id`) ON DELETE SET NULL ON UPDATE CASCADE,
FOREIGN KEY (`reported_user_id`) REFERENCES `cockatrice_users`(`id`) ON DELETE SET NULL ON UPDATE CASCADE,
FOREIGN KEY (`assigned_to`) REFERENCES `cockatrice_users`(`id`) ON DELETE SET NULL ON UPDATE CASCADE,
FOREIGN KEY (`resolved_by`) REFERENCES `cockatrice_users`(`id`) ON DELETE SET NULL ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 DEFAULT COLLATE utf8mb4_unicode_ci;
CREATE TABLE IF NOT EXISTS `cockatrice_report_comments` (
`id` int(11) unsigned NOT NULL AUTO_INCREMENT,
`report_id` int(11) unsigned NOT NULL,
`author_name` varchar(35) NOT NULL,
`author_id` int(7) unsigned NULL,
`comment_text` text NOT NULL,
`created_at` datetime NOT NULL,
`is_moderator` tinyint(1) NOT NULL DEFAULT 0,
`notified` tinyint(1) NOT NULL DEFAULT 0,
PRIMARY KEY (`id`),
INDEX `idx_report_id` (`report_id`),
INDEX `idx_notified` (`notified`),
FOREIGN KEY (`report_id`) REFERENCES `cockatrice_reports`(`id`) ON DELETE CASCADE ON UPDATE CASCADE,
FOREIGN KEY (`author_id`) REFERENCES `cockatrice_users`(`id`) ON DELETE SET NULL ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 DEFAULT COLLATE utf8mb4_unicode_ci;
ALTER TABLE `cockatrice_users`
ADD COLUMN `force_password_change` tinyint(1) NOT NULL DEFAULT 0
AFTER `passwordLastChangedDate`;
UPDATE cockatrice_schema_version SET version=36 WHERE version=35;