mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-23 01:55:10 -07:00
fa89662172
Address review: silently prepending the Scryfall named-picture URL to the download list whenever a non-English card language was active was surprising, consumed quota per card when it failed, and could grab the wrong (canon) art on name collisions, with no way to turn it off. The insert is now opt-in and user-controlled: changing the card language adds the template to the top of the download URLs once (persisted, documented in the re-import prompt, and editable/removable in the deck editor settings), while the picture loader no longer injects it at request time.
67 lines
2.1 KiB
C++
67 lines
2.1 KiB
C++
#include "download_settings.h"
|
|
|
|
#include "settings_manager.h"
|
|
|
|
const QStringList DownloadSettings::DEFAULT_DOWNLOAD_URLS = {
|
|
"https://cards.scryfall.io/large/!prop:side!/!set:uuid_substr_0_1!/!set:uuid_substr_1_1!/!set:uuid!.jpg",
|
|
"https://api.scryfall.com/cards/!set:uuid!?format=image&face=!prop:side!&lang=!sflang!",
|
|
"https://api.scryfall.com/cards/multiverse/!set:muid!?format=image&lang=!sflang!",
|
|
"https://gatherer.wizards.com/Handlers/Image.ashx?multiverseid=!set:muid!&type=card",
|
|
"https://gatherer.wizards.com/Handlers/Image.ashx?name=!name!&type=card"};
|
|
|
|
const QString DownloadSettings::SCRYFALL_NAMED_LOCALIZED_URL =
|
|
"https://api.scryfall.com/cards/named?fuzzy=!localizedName!&lang=!sflang!&format=image&face=!prop:side!";
|
|
|
|
DownloadSettings::DownloadSettings(const QString &settingPath, QObject *parent = nullptr)
|
|
: SettingsManager(settingPath + "downloads.ini", "downloads", QString(), parent)
|
|
{
|
|
}
|
|
|
|
void DownloadSettings::setDownloadUrls(const QStringList &downloadURLs)
|
|
{
|
|
setValue(QVariant::fromValue(downloadURLs), "urls");
|
|
}
|
|
|
|
QStringList DownloadSettings::getAllURLs() const
|
|
{
|
|
return getValue("urls").toStringList();
|
|
}
|
|
|
|
void DownloadSettings::resetToDefaultURLs()
|
|
{
|
|
setValue(QVariant::fromValue(DEFAULT_DOWNLOAD_URLS), "urls");
|
|
}
|
|
|
|
bool DownloadSettings::addLocalizedScryfallUrl()
|
|
{
|
|
const QStringList urls = getAllURLs();
|
|
if (urls.contains(SCRYFALL_NAMED_LOCALIZED_URL)) {
|
|
return false;
|
|
}
|
|
QStringList updated = urls;
|
|
updated.prepend(SCRYFALL_NAMED_LOCALIZED_URL);
|
|
setDownloadUrls(updated);
|
|
return true;
|
|
}
|
|
|
|
bool DownloadSettings::getPicDownload() const
|
|
{
|
|
return getValue("pictureDownload", QString(), QString(), true).toBool();
|
|
}
|
|
|
|
void DownloadSettings::setPicDownload(bool _picDownload)
|
|
{
|
|
setValue(_picDownload, "pictureDownload");
|
|
emit picDownloadChanged();
|
|
}
|
|
|
|
bool DownloadSettings::getDownloadSpoilersStatus() const
|
|
{
|
|
return getValue("downloadSpoilers", QString(), QString(), false).toBool();
|
|
}
|
|
|
|
void DownloadSettings::setDownloadSpoilerStatus(bool _spoilerStatus)
|
|
{
|
|
setValue(_spoilerStatus, "downloadSpoilers");
|
|
emit downloadSpoilerStatusChanged();
|
|
}
|