[Game] Reveal multiple distinct random hand cards to a recipient (#7753)

* Add distinct random hand reveals with private recipient delivery

* Route random hand reveals through PlayerActions

Keep command creation, dispatch and response handling in the game action
layer. HandMenu requests the typed operation and presents the count and
failure dialogs. Show the chosen recipient, distinguish the count action
from the immediate single-card reveal, and use the game window as parent.

* Apply project formatting to random-reveal warning construction

* Simplify random reveal to follow existing command patterns

Forward server dispatch through cmdRevealRandomCards and use ordinary PlayerActions command sending. Remove the bespoke server-version error UI and long-lived-object guards.

Reduce the test from 246 to 150 lines with two focused cases using the current RoleInfo player API, preserving distinct-card, private-event and rejected-count coverage.

* Extract the shared reveal helper and name the test's CardRef fields

RickyRister asked for cmdRevealCards and cmdRevealRandomCards to share a
helper instead of threading a randomCount parameter through the reveal
virtual. Restore the three-argument cmdRevealCards signature, resolve the
reveal preconditions and zone in resolveRevealZone, and let both commands
build their card list and hand it to revealCards, which owns the private and
public Event_RevealCards construction and the enqueue. The random command no
longer fabricates a Command_RevealCards with the -2 sentinel to re-enter the
legacy path; its behaviour is unchanged.

Name the CardRef fields in random_reveal_test instead of relying on
declaration order, and state in the user documentation that a rejected
reveal is not reported in the client, matching what the client does.

---------

Co-authored-by: Lukas Brübach <44814898+BruebachL@users.noreply.github.com>

tests/CMakeLists.txt

@@ -356,6 +356,17 @@ cockatrice_add_test(
   LABELS
   server
 )
+cockatrice_add_test(
+  NAME
+  random_reveal_test
+  SOURCES
+  random_reveal_test.cpp
+  LIBS
+  libcockatrice_network_server_remote
+  libcockatrice_rng
+  LABELS
+  server
+)
 cockatrice_add_test(
   NAME
   server_game_join_test

tests/random_reveal_test.cpp

@@ -0,0 +1,151 @@
+#include "game/game_config.h"
+#include "game/server_abstract_player.h"
+#include "game/server_card.h"
+#include "game/server_cardzone.h"
+#include "game/server_game.h"
+#include "movecard_tests/server_test_helpers.h"
+#include "server_abstractuserinterface.h"
+#include "server_response_containers.h"
+#include "server_room.h"
+
+#include <QCoreApplication>
+#include <gtest/gtest.h>
+#include <libcockatrice/deck_list/deck_list.h>
+#include <libcockatrice/protocol/pb/command_deck_select.pb.h>
+#include <libcockatrice/protocol/pb/command_reveal_cards.pb.h>
+#include <libcockatrice/protocol/pb/event_reveal_cards.pb.h>
+#include <libcockatrice/protocol/pb/game_event_container.pb.h>
+#include <libcockatrice/rng/rng_abstract.h>
+#include <libcockatrice/utility/zone_names.h>
+#include <memory>
+
+namespace
+{
+class FirstRng : public RNG_Abstract
+{
+    unsigned int rand(int min, int) override
+    {
+        return min;
+    }
+} firstRng;
+
+class User : public Server_AbstractUserInterface
+{
+public:
+    User(Server *server, const char *name) : Server_AbstractUserInterface(server)
+    {
+        ServerInfo_User info;
+        info.set_name(name);
+        setUserInfo(info);
+    }
+    int getLastCommandTime() const override
+    {
+        return 0;
+    }
+    bool addSaidMessageSize(int) override
+    {
+        return true;
+    }
+    void sendProtocolItem(const Response &) override
+    {
+    }
+    void sendProtocolItem(const SessionEvent &) override
+    {
+    }
+    void sendProtocolItem(const RoomEvent &) override
+    {
+    }
+    void sendProtocolItem(const GameEventContainer &) override
+    {
+    }
+};
+
+class RandomReveal : public ::testing::Test
+{
+protected:
+    FakeServer server;
+    User owner{&server, "Owner"}, target{&server, "Target"};
+    Server_Room room{0, 0, "", "", "", "", false, "", {}, &server};
+    std::unique_ptr<Server_Game> game;
+    Server_AbstractPlayer *player;
+    Server_CardZone *hand;
+    ResponseContainer response{1};
+
+    void SetUp() override
+    {
+        GameConfig config;
+        config.creatorInfo = *owner.getUserInfo();
+        config.gameId = 1;
+        config.maxPlayers = 2;
+        config.shareDecklistsOnLoad = false;
+        game = std::make_unique<Server_Game>(config, &room);
+        game->addPlayer(&owner, response, {});
+        game->addPlayer(&target, response, {});
+        for (auto *participant : game->getPlayers()) {
+            GameCommand command;
+            command.MutableExtension(Command_DeckSelect::ext)
+                ->set_deck(DeckList().writeToString_Native().toStdString());
+            GameEventStorage events;
+            ASSERT_EQ(participant->processGameCommand(command, response, events), Response::RespOk);
+            participant->setReadyStart(true);
+        }
+        game->startGameIfReady(false);
+        QCoreApplication::processEvents();
+        ASSERT_TRUE(game->getGameStarted());
+        player = game->getPlayer(0);
+        hand = player->getZones().value(ZoneNames::HAND);
+        for (int i = 0; i < 4; ++i) {
+            hand->insertCard(
+                new Server_Card({.name = "Twin", .providerId = QString::number(i)}, player->newCardId(), i, 0), -1, 0);
+        }
+    }
+
+    Response::ResponseCode reveal(int count, GameEventStorage &events)
+    {
+        GameCommand command;
+        auto *request = command.MutableExtension(Command_RevealRandomCards::ext);
+        request->set_zone_name(ZoneNames::HAND);
+        request->set_player_id(1);
+        request->set_number_of_cards(count);
+        return player->processGameCommand(command, response, events);
+    }
+};
+
+TEST_F(RandomReveal, DistinctPhysicalCardsArePrivateAndLeaveTheHandUnchanged)
+{
+    const auto original = hand->getCards();
+    GameEventStorage events;
+    ASSERT_EQ(reveal(2, events), Response::RespOk);
+    ASSERT_EQ(events.getGameEventList().size(), 2);
+    EXPECT_EQ(events.getPrivatePlayerId(), 1);
+    const auto *privateEvent = events.getGameEventList().at(0);
+    EXPECT_EQ(privateEvent->getRecipients(), GameEventStorageItem::SendToPrivate);
+    const auto &cards = privateEvent->getGameEvent().GetExtension(Event_RevealCards::ext);
+    ASSERT_EQ(cards.cards_size(), 2);
+    EXPECT_NE(cards.cards(0).id(), cards.cards(1).id());
+    const auto *publicEvent = events.getGameEventList().at(1);
+    EXPECT_EQ(publicEvent->getRecipients(), GameEventStorageItem::SendToOthers);
+    const auto &notice = publicEvent->getGameEvent().GetExtension(Event_RevealCards::ext);
+    EXPECT_EQ(notice.cards_size(), 0);
+    EXPECT_EQ(notice.number_of_cards(), 2);
+    EXPECT_EQ(hand->getCards(), original);
+}
+
+TEST_F(RandomReveal, InvalidCountsDoNotQueueAnyReveal)
+{
+    for (int count : {0, -1, 5}) {
+        GameEventStorage events;
+        EXPECT_NE(reveal(count, events), Response::RespOk);
+        EXPECT_TRUE(events.getGameEventList().isEmpty());
+    }
+}
+} // namespace
+
+RNG_Abstract *rng = &firstRng;
+
+int main(int argc, char **argv)
+{
+    QCoreApplication application(argc, argv);
+    ::testing::InitGoogleTest(&argc, argv);
+    return RUN_ALL_TESTS();
+}