jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-11-10 20:13:24 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Address review findings

Browse source
This commit is contained in:
Lukas Brübach 2026-11-08 14:46:29 +01:00
parent 44ac98885a
commit 4a0c956062
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cockatrice/src/interface/palette_editor/palette_grid_widget.cpp
View file

@ -61,8 +61,10 @@ static const QMap<QPalette::ColorRole, const char *> ROLE_DESCRIPTIONS = {
};
static const QMap<AppColor::Role, const char *> APP_ROLE_DESCRIPTIONS = {
{AppColor::AccentStrong, QT_TR_NOOP("Vivid primary accent (e.g. home-tab button gradient start)")},
{AppColor::AccentSoft, QT_TR_NOOP("Lightened, desaturated accent (e.g. home-tab button gradient end)")},
{AppColor::AccentStrong,
QT_TRANSLATE_NOOP("PaletteGridWidget", "Vivid primary accent (e.g. home-tab button gradient start)")},
{AppColor::AccentSoft,
QT_TRANSLATE_NOOP("PaletteGridWidget", "Lightened, desaturated accent (e.g. home-tab button gradient end)")},
{AppColor::Positive,
QT_TRANSLATE_NOOP("PaletteGridWidget", "Positive state and additive actions (ready, add, increment)")},
{AppColor::Negative,

6
cockatrice/src/interface/theme_icon.cpp
View file

@ -256,7 +256,11 @@ private:
// variant is never a bare digit, so the key spaces cannot collide. A
// badge also varies by glyph color, because the same tone can switch
// between a white and a near-black glyph at different lightnesses.
const QColor tone = resolvedHasSentinel ? tint.resolve(mode) : QColor();
// The selected-row contrast fallback exists for a thin glyph painted
// directly on the highlight. A badge or sticker brings its own ring and
// contrast glyph, so repainting its whole tone with HighlightedText
// would collapse every badge on a selected row into one gray disc.
const QColor tone = resolvedHasSentinel ? tint.resolve(treated ? QIcon::Normal : mode) : QColor();
QByteArray variant;
if (badge) {
variant = QByteArrayLiteral("B|") + tone.name(QColor::HexRgb).toLatin1() + '|' +