[DeckSync] Address auto-sync review: disconnect, backfill and modal conflicts

- Fail the run when the connection drops while a sync is running, and clear
  the active conflict, so the queue is not sent on a dead client and a
  re-login as another account never receives this profile's uploads.
- Backfill last_modified from upload_time in the 37 -> 38 migration and drop
  the "last_modified is null" arm from the sync-check query, so rows that
  predate the column stop reporting as changed on every poll.
- Skip conflicts during auto runs and report how many were skipped, instead
  of opening the modal conflict dialog from a timer or a file-watcher event.

cockatrice/src/interface/deck_sync/deck_sync_profile.h

@@ -9,15 +9,16 @@
 #include <QString>
 
 /**
- * @struct DeckSyncProfile
+ * @class DeckSyncProfile
  * @brief Identifies which server and login a sync sidecar belongs to.
  *
  * A local deck folder can sync against several servers. Every server login
  * gets its own profile, and every profile gets its own sidecar file, so
  * switching servers never mixes up remote deck ids.
  */
-struct DeckSyncProfile
+class DeckSyncProfile
 {
+public:
     QString host;     ///< Server hostname as entered by the user.
     int port = 0;     ///< Server port.
     QString username; ///< Login name on that server.

cockatrice/src/interface/deck_sync/deck_sync_sidecar.cpp

@@ -47,11 +47,12 @@ bool DeckSyncSidecar::load()
             continue;
         }
         const QJsonObject entry = it.value().toObject();
-        const DeckSyncRecord record{.guid = entry.value("guid").toString(),
-                                    .remoteId = entry.value("remoteId").toInt(-1),
-                                    .baseHash = entry.value("baseHash").toString(),
-                                    .lastSyncSecs = static_cast<qint64>(entry.value("lastSync").toDouble()),
-                                    .deleted = entry.value("deleted").toBool(false)};
+        DeckSyncRecord record;
+        record.guid = entry.value("guid").toString();
+        record.remoteId = entry.value("remoteId").toInt(-1);
+        record.baseHash = entry.value("baseHash").toString();
+        record.lastSyncSecs = static_cast<qint64>(entry.value("lastSync").toDouble());
+        record.deleted = entry.value("deleted").toBool(false);
         recordMap.insert(it.key(), record);
     }
     return true;

libcockatrice_deck_list/libcockatrice/deck_list/deck_diff.cpp

@@ -70,13 +70,14 @@ DeckDiffResult diff(const DeckList &oldDeck, const DeckList &newDeck)
         const int oldCount = oldCounts.value(key, 0);
         const ZoneCardInfo newInfo = newInfos.value(key, ZoneCardInfo());
         if (oldCount != newInfo.count) {
-            const DeckCardChange change{.zone = key.first,
-                                        .cardName = key.second,
-                                        .oldCount = oldCount,
-                                        .newCount = newInfo.count,
-                                        .cardSetShortName = newInfo.cardSetShortName,
-                                        .cardSetNumber = newInfo.cardSetNumber,
-                                        .cardProviderId = newInfo.cardProviderId};
+            DeckCardChange change;
+            change.zone = key.first;
+            change.cardName = key.second;
+            change.oldCount = oldCount;
+            change.newCount = newInfo.count;
+            change.cardSetShortName = newInfo.cardSetShortName;
+            change.cardSetNumber = newInfo.cardSetNumber;
+            change.cardProviderId = newInfo.cardProviderId;
             result.changes.append(change);
         }
     }