3708 commits

Author	SHA1	Message	Date
DawnFire42	1a62f82aee	Refactor vertical card stacking with clip containers for variable zone sizes (#6774) ... * Refactor vertical card stacking with opt-in overflow for variable zone sizes Introduce a shared vertical stacking layout system in SelectZone that replaces the old divideCardSpaceInZone() free function with structured layout computation (StackLayoutParams, ZoneLayout, computeZoneLayout). By default, cards are guaranteed to fit within zone bounds (no overflow). Zones can opt-in to bottom overflow via allowBottomOverflow flag, with sqrt-scaled compression for smooth visual transitions. A clip container mechanism is available for future zones that need visual clipping. Key changes: - SelectZone: new layout engine with allowBottomOverflow opt-in; clip container infrastructure for future zones needing visual clipping - StackZone: uses new layout (no overflow); adds setHeight() for dynamic resizing capabilities - HandZone: vertical layout delegates to SelectZone's shared stacking - AbstractCardItem: preserves hover z-value during layout passes; invalidates scene rect on hover exit for proper sibling repainting - CardZone::onCardAdded made virtual for clip container reparenting - Zone widths updated to CardDimensions::WIDTH_F * 1.5 * Changed anonymous namespace for static and braced functions * CI tests re-run	2026-05-10 19:10:14 -07:00
BruebachL	dbaf5f2e05	[GameSelector] Don't conditionally initialize gamesListProxyModel (#6870) ... Took 44 seconds Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-05-10 11:35:17 +02:00
RickyRister	9c53dad4b8	[Game] Refactor: add selectedCards method to GameScene (#6859)	2026-05-09 17:03:48 -07:00
RickyRister	7814204fe2	[Game] Refactor: explicitly pass params from card counter actions (#6780)	2026-05-09 13:20:33 -07:00
RickyRister	cdb171f201	[Game] Refactor: move setCardAttrHelper to PlayerEventHandler (#6772)	2026-05-09 13:10:56 -07:00
RickyRister	48e21aad38	[Game] Refactor: move parsePT to a static method (#6860)	2026-05-09 12:55:11 -07:00
RickyRister	8845a75627	[GameSelector] Fix bug with hideNotBuddyCreatedGames checkbox (#6858)	2026-05-09 04:08:30 -07:00
BruebachL	caf2bb9ded	Pull client networking out of window_main and into remote_connection_controller (#6796) ... * Pull client networking out of window_main and into remote_connection_controller Took 2 minutes * Things. Took 13 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-05-09 12:50:53 +02:00
RickyRister	985936a917	[GameModel] Refactor game filters options into struct (#6856)	2026-05-09 02:45:33 -07:00
ZeldaZach	efe52b5412	Fix windows copying over CMakeFiles to themes	2026-05-08 10:28:14 -04:00
BruebachL	a4c2b1411f	Utility method to check if a theme is supposed to be in dark or light mode. (#6785) ... * Utility method to check if a theme is supposed to be in dark or light mode. Took 22 minutes Took 4 seconds * Method is public. Took 3 minutes * Add a utility method to check if we're using a built-in theme Took 3 minutes Took 3 seconds * Use built-in theme detection for home screen. Took 6 minutes * Re-polish on theme change Took 2 minutes * Fetch background on theme change. Took 4 minutes Took 6 seconds * No need to double polish. Took 4 minutes * No need to repaint. Took 32 seconds * Only repolish visible widgets. Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-05-08 13:47:14 +02:00
RickyRister	19dbb17fb9	[SettingsManager] Properly handle multithreaded access again (#6844) ... * [SettingsManager] Properly handle multithreaded access again * Add comment * Add batch write function --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-05-05 21:03:01 +02:00
BruebachL	d30690236a	Reload card db and notify enabled sets change on "Manage Sets" dialog save (#6837) ... * Reload card db and notify enabled sets change on "Manage Sets" dialog save Took 1 hour 18 minutes Took 6 seconds * Extract to method, also notify on "Reload db" and "new sets found" Took 3 minutes Took 4 seconds * Add an "always enable new sets" fuse to "new sets found" dialog Took 11 minutes * Always debounce modelDirty() with dirty() timer. Took 29 minutes Took 3 minutes * Performance improvements for settings by not constructing a new settings object on every single set() call (this forced a sync to/from fs but it seems fine to just rely on Qts own periodic sync?) Took 23 minutes Took 3 seconds --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-05-03 03:11:10 +02:00
BruebachL	9ac9a0c73a	[Game] Add a coinflip shortcut. (#6829) ... Took 18 minutes Took 6 seconds Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-29 22:09:30 +02:00
BruebachL	314a577807	Do not allow users to remove VDE functionality by closing tabs (#6838) ... * Do not allow users to remove VDE functionality by closing tabs. Took 6 minutes * Set filter toolbar visible on delayed initialization. Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-29 12:37:47 +02:00
transifex-integration[bot]	8953ae3c67	Updates for project Cockatrice and language de (#6833) ... * Translate cockatrice/cockatrice_en@source.ts in de 100% translated source file: 'cockatrice/cockatrice_en@source.ts' on 'de'. * Translate cockatrice/cockatrice_en@source.ts in de 100% translated source file: 'cockatrice/cockatrice_en@source.ts' on 'de'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>	2026-04-27 21:16:10 +02:00
ebbit1q	b1fe4c85d3	fix sending decks to tappedout (#6832)	2026-04-23 02:28:12 +02:00
Vorliz	a20f3c0fb4	Fix #6659: Correct logging for bottom-of-library card moves (#6764) ... * Fix #6659: Correct logging for bottom-of-library card moves Cause: - This issue happens due to logic of moving the card from the top of the deck being reused when moving from the bottom of the deck, in a way that makes it impossible to check if the card came from the bottom. Resolution: - Updated the logging logic in the client for card moves. - Added a gRPC parameter ('is_from_bottom') for card moves. - Updates the server logic to reverse the order of the card move if the 'is_from_bottom' parameter is true. - Added a test to show the expected behaviour of the fix. NOTE: While the changes in this patch seem big, this is due to changing the loop in the moveCard function to a helper function, in order to make the bug fix change. The only change to the loop was to pass a variable attribution to the moveCard function because it was redundant to be in the loop. * chore: run format on test * refactor: new way to check if a move is from the bottom of the deck * refactor: change isFromBottom check to static function * update comments Co-authored-by: ebbit1q <ebbit1q@gmail.com> --------- Co-authored-by: ebbit1q <ebbit1q@gmail.com>	2026-04-21 19:05:31 +02:00
BruebachL	9226bc9ddd	[TabArchidekt] Place sideboard categories into the sideboard. (#6824) ... Took 35 minutes Took 3 seconds Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-21 08:09:39 +02:00
ebbit1q	501c4b96d4	clear all players when closing game tab (#6828) ... this prevents issues caused by items in play when using the player destructor in the wrong order	2026-04-21 08:09:20 +02:00
ebbit1q	6ab947418c	add an isEmpty method to printing info (#6805) ... no reason, I just find it easier to understand	2026-04-21 01:26:08 +02:00
BruebachL	6765831b92	Change button colors to be palette aware. (#6821) ... * Change button colors to be palette aware. Took 13 minutes Took 41 seconds Took 15 seconds * Change button style. Took 24 minutes Took 4 seconds --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-20 17:47:15 +02:00
BruebachL	98c4e829f8	[GameSelector/Filters] Properly sync toolbar and dialog. (#6822) ... Took 59 minutes Took 2 minutes Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-20 13:19:29 +02:00
BruebachL	ccb9901b28	[DeckAnalytics] Add a checkbox to include/exclude sideboard for calculation (#6823) ... * [DeckAnalytics] Add a checkbox to include/exclude sideboard for calculation Took 15 minutes * default to false, actually Took 2 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-19 23:08:56 +02:00
BruebachL	682ac4ed0c	Add -R option in Windows NSIS script for silent upgrade (#6818) ... * Add -R option in Windows NSIS script Took 23 minutes * Small fix. Took 3 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-19 01:07:38 +02:00
ebbit1q	e918856fa4	clear player before removing it from the scene (#6817) ... revert #6740	2026-04-18 12:50:53 +02:00
github-actions[bot]	87c4216e80	Update translation files (#6813) ... Co-authored-by: github-actions <github-actions@github.com>	2026-04-15 20:41:45 +02:00
BruebachL	832f70496a	[EDHRec] Fix unintentional navigation on card right click (#6814) ... Don't double emit cardClicked and also pass along the mouseEvent so we can check if it's a left or right click. Took 26 minutes Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-15 14:14:30 +02:00
ebbit1q	f97864b72b	set the minimum qt6 version to 6.4 (#6811) ... * set the minimum qt6 version to 6.4 this will be separate from the qt5 removal after release * add include for optional	2026-04-14 00:59:46 +02:00
ebbit1q	338c56678a	add workaround for windows11 theme (#6810)	2026-04-13 14:49:31 +02:00
ebbit1q	2e10b2f5d5	make general settings scrollable (#6800)	2026-04-12 02:38:04 +02:00
ebbit1q	92fe406c22	remove break statement when closing views (#6801) ... it's possible that multiple views need to be closed this is an oversight of #4570	2026-04-12 02:37:43 +02:00
transifex-integration[bot]	9aa5702e14	Translate cockatrice_en@source.ts in en_US (#6783) ... 100% translated source file: 'cockatrice_en@source.ts' on 'en_US'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>	2026-04-09 21:27:14 +02:00
ebbit1q	2d412bfe52	fix cardloading on qt5 (#6790)	2026-04-09 21:16:38 +02:00
RickyRister	ac06fb9d1c	[Game] Fix crash by properly parenting QObjects (#6788)	2026-04-09 15:02:00 +02:00
BruebachL	d7b31f2f9d	Set OracleWizard style to "Modern" instead of "Aero" (#6778) ... * Use fusions own palette. Took 6 minutes * Start from default palette always. Took 4 minutes * Add modern style. Took 24 seconds * Scope this fix to Windows. Took 4 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-07 15:58:42 +02:00
BruebachL	635fae101d	Use palette colors for resizable panel stylesheets. (#6782) ... Took 7 minutes Took 5 seconds Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-07 15:57:03 +02:00
BruebachL	335022c4aa	Include themes (#6781) ... * Properly reset default theme. Took 9 minutes * Descend in preference on windows. Took 9 minutes * Also reset style for custom themes. Took 3 minutes * Try things Took 9 minutes * Add modern windows style. Took 8 minutes * Update theme_manager.cpp --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-04-07 15:02:00 +02:00
Bruno Alexandre Rosa	dbed6890da	feat: support expressions when setting card counters (#6753) ... * feat: enable expressions in card counters * fix includes * fix multiple selection * cleanup useless conversions * const ref where possible * do not use const, be consistent with local patterns in the file	2026-04-06 22:36:45 -07:00
ebbit1q	3ec9ae9772	fix compiling on arch (#6768) ... * fix compiling on arch * redo all the logging in affected files	2026-04-05 21:52:46 +02:00
github-actions[bot]	9dfac77ba2	Update translation source strings (#6762)	2026-04-01 05:49:17 +02:00
ebbit1q	42bd8164a0	remove hardcoded white in vde banner widget (#6684) ... * remove hardcoded white in vde banner widget * set text color to white on higher opacities	2026-03-27 18:10:29 +01:00
ebbit1q	abf6e72ad1	add a nulcheck in the card item animation timer (#6740)	2026-03-27 18:08:51 +01:00
RickyRister	74cce5ccb2	[SettingsManager] Properly handle multithreaded access (#6747)	2026-03-27 17:12:49 +01:00
DawnFire42	dd053c76df	[Game] Improve context menus and fix face-down play from stack (#6739) ... Reorganize card context menus across table, stack, and graveyard/exile zones for better consistency: promote Draw Arrow and Clone actions, move related card entries to the bottom, add Play/Play Face Down to the stack menu, and flatten if/else blocks with early returns. Also fix playCard() ignoring the faceDown flag when routing instants/sorceries from the stack, which sent them to the graveyard instead of the table.	2026-03-25 15:03:59 -07:00
scotland0208	5ef428b9d0	Add visual indicator to toggle untap button (#6737) ... * Add visual indicator to toggle untap button * Rename button to match tooltip * Change name of string in shortcut settings	2026-03-25 14:15:08 -07:00
DawnFire42	94ea574c76	Add moveToTable context menu action and extract tableRowToGridY helper (#6738) ... Adds a Table option to the Move menu, allowing cards to be moved directly to the battlefield from any zone. Extracts the repeated tableRow-to-grid-Y conversion logic into TableZone::tableRowToGridY(), consolidating five call sites and fixing a latent bug where cards with tableRow > 2 could land on the wrong row.	2026-03-24 13:45:52 -07:00
DawnFire42	70b41c2095	refactor: extract AbstractPlayerComponent interface for polymorphic player component management. (#6696) ... Non-QObject polymorphic interface with setShortcutsActive(), setShortcutsInactive(), and retranslateUi(). Uses regular multiple inheritance to avoid diamond inheritance with Qt's MOC. All zone menus, SayMenu, and AbstractCounter implement this interface. PlayerMenu manages them via a managedComponents list with two template helpers (addManagedMenu/registerManagedComponent), replacing individual if-guarded lifecycle calls with a single polymorphic loop. SayMenu now owns its shortcut and translation lifecycle instead of having PlayerMenu manage its title and shortcuts externally. Counters are iterated via Player::getCounters() rather than managedComponents to avoid duplicating the authoritative owner's map.	2026-03-24 12:31:34 -07:00
ebbit1q	aa85a39d6a	expand local game life total limits (#6730)	2026-03-24 00:16:48 +01:00
RickyRister	bc219191db	[Game] Refactor options in DlgMoveTopCardsUntil into struct (#6718)	2026-03-22 12:32:42 +01:00