9 commits

Author	SHA1	Message	Date
Lukas Brübach	0909d356e0	Various fixes ... Took 14 minutes	2026-11-02 21:52:40 +01:00
BruebachL	d603a2bb6a	[Tooling] Apply include-what-you-use across the tree (#7396) ... * [DeckList] Apply include-what-you-use to libcockatrice_deck_list * [IWYU] Apply include-what-you-use across the tree Run one whole-tree IWYU pass over the libcockatrice_* libraries, the Cockatrice client, Oracle, Servatrice and the test suite, so each translation unit includes what it uses directly and forward-declares what it does not need. IWYU only analyses real translation units, never the moc code CMake generates from Q_OBJECT headers, so it strips includes that moc output silently relies on. Where a type is passed by value (or nested in a QList/QMap) in a signal or slot signature, the generated moc code needs the complete type; those includes are kept with an explanatory `// IWYU pragma: keep`. The same holds for Q_DECLARE_METATYPE targets such as QSqlDatabase. A handful of includes are added by hand where callers brace-initialize a const-reference parameter, which also requires the complete type. Applied as a single commit on purpose: stripping includes from the libcockatrice_* headers is precisely what breaks the client, test and server translation units, and the fixes for those live in the same translation units. Splitting by component would therefore leave intermediate commits that do not compile. All 426 modified Q_OBJECT/Q_GADGET headers were verified to be moc-self-contained by compiling each generated moc_*.cpp standalone; several built only because of moc include ordering in mocs_compilation.cpp before the keep-includes were added. * [Tooling] Emit public Qt headers and fix IWYU fallout CI found Three problems the local build could not see, all because a green local build only proves the configuration it was run under. Private Qt headers. IWYU emitted private, lowercase Qt headers, and qtypes.h does not exist at all before Qt 6.9, so the Debian 12 and Ubuntu 24.04 jobs on Qt 6.4.2 failed to compile. The generator only emitted a mapping when the capital header name mirrored the private one (QAbstractAnimation for qabstractanimation.h), so qtypes.h, which is wrapped by QtTypes instead, got no mapping and kept the private spelling. Map it explicitly to <QtTypes>, which is public since Qt 5 and provides the same typedefs either way, and rewrite the 100 affected includes. Do not generalize this to "prefer any Qt* wrapper". The table is generated from whichever Qt is installed, and the wrappers are not equally old: QtLogging only appeared in Qt 6.8 and QtMinMax in 6.5, so that heuristic trades one breakage for another. Every other lowercase header still in the tree has shipped publicly since Qt 5, so those are left alone. Platform-guarded includes. IWYU only sees the preprocessor configuration it is handed, so it dropped an include that only the macOS branch of main.cpp needs, and the macOS jobs failed on an undeclared UrlSchemeEventFilter. Restore the include. Force-compiling every file that carries a platform guard under Q_OS_MAC, Q_OS_MACOS and __APPLE__ reports nothing else, so the macOS branches are covered rather than assumed. shellcheck. Drop a leftover variable and stop assigning the include-what-you-use lookup, which was only ever an existence check. * [Tooling] Map Qt 6.5+ split headers to QtGlobal for Qt 6.4 compatibility IWYU emitted QtTypes, QtPreprocessorSupport, QtVersionChecks, QtAssert, QtMinMax, QtClassHelperMacros, QtEnvironmentVariables and QtTranslation. Qt 6.5 split those declarations out of qglobal.h into separate headers, so neither the Qt* wrapper nor the q*.h private name exists on the oldest Qt we support (6.4.2), and Debian 12 / Ubuntu 24.04 fail with "No such file or directory". qtypes.h is worse still: it only appeared in Qt 6.9. QtGlobal is the one spelling that works across the whole supported range. It has been public since Qt 5, defines these declarations itself up to Qt 6.4, and includes the split headers from Qt 6.5 on, so redirect all eight private headers to it and collapse the affected includes in the tree. Curated overrides now take precedence over the name-mirroring rule, which cannot know about Qt version floors because the mapping is generated from whatever Qt is installed. That rule was mapping qtversionchecks.h to <QtVersionChecks> even with an override present, because the override was only consulted as a fallback. A curated key that matches nothing is now a hard error rather than a silent fallback, and the redirected headers are no longer advertised as the home of a symbol. Verified every Qt include in the tree resolves against the real qt6-base-dev 6.4.2 package: 15 distinct includes, 0 missing. * [Tooling] Map QOverload to QtGlobal and drop the QMetaMethodArgument include Two more headers IWYU emitted do not exist on Qt 6.4.2: QOverload was split out of qglobal.h in Qt 6.5, so on 6.4.2 it is declared in qglobal.h directly and the standalone header is a hard error. QtGlobal covers both, so map qoverload.h to it like the other 6.5+ split headers. QMetaMethodArgument is never referenced anywhere in the tree. It is a bare forwarder for qobjectdefs.h that our generator advertised as a class symbol, which is how IWYU came to add the include at all. The symbol mappings are generated from header names, so they cannot tell a forwarder that happens to be capitalised from a real class; removing the unused include is the fix, and the generic case stays a known limitation of the generator. Extending the audit to every Q* header (an earlier pass only matched headers starting with "Qt" or lowercase q*.h, so it missed all of them) against the real qt6-base-dev, qt6-multimedia-dev, qt6-declarative-dev, qt6-svg-dev and qt6-websockets-dev 6.4.2 packages: 341 distinct Qt includes, 0 missing. * [Game] Give moc the complete CardItem type in player_actions.h player_actions.h forward declares CardItem but passes QList<CardItem *> by value in actPlay/actPlayFacedown/actHide. moc instantiates the metatype for those parameters, and on Qt 6.4 that expands to sizeof(CardItem), so Ubuntu 24.04 fails with "invalid application of 'sizeof' to incomplete type 'CardItem'". Newer Qt tolerates the incomplete type, which is why only the 6.4.2 jobs failed. Include the defining header with an IWYU pragma keep, matching how the other MOC-required includes in this area are handled. * [Game] Give moc the complete ServerInfo_Card type player_logic.h, game_scene.h, view_zone.h and view_zone_widget.h forward declare ServerInfo_Card but pass QList<const ServerInfo_Card *> through signal and slot signatures. moc instantiates the metatype for those parameters, which Qt 6.4 expands to sizeof(ServerInfo_Card), so the connect in game_scene.cpp fails on Debian 12 and Ubuntu 24.04 with "invalid application of 'sizeof' to incomplete type 'const ServerInfo_Card'". Newer Qt tolerates it, so only the 6.4.2 jobs failed. Include the generated protobuf header with an IWYU pragma keep, following the pattern already used for ServerInfo_Player and ServerInfo_User in game_event_handler.h. * [Client] Complete the types Qt 6.4 needs for connect and moc Qt 6.4 expands QMetaType::fromType on the normalised argument list of a PMF connect and on moc-generated metatypes, which requires sizeof on every signal and slot parameter. Newer Qt tolerates forward declarations there, so only the Debian 12 and Ubuntu 24.04 jobs failed, with "invalid application of 'sizeof' to incomplete type" for QMouseEvent, QPrinter and GameReplay. Replace the forward declarations with the real includes: - QMouseEvent in the nine widget headers that pass it through signals - QPrinter in abstract_tab_deck_editor.cpp, for the actPrintDeck lambda - game_replay.pb.h in tab_replays.h. GameReplay is a protobuf message, so the project's game/replay.h only forward declares it and cannot supply the complete type. Found by recompiling all 1918 project TUs against the Debian Qt 6.4.2 headers, which reproduces those two CI jobs locally in one pass. * [Client] Complete Release and QMenu for Qt 6.4 moc and connect Continuing the Qt 6.4 complete-type sweep: - window_main.cpp connects ClientUpdateChecker::finishedCheck to MainWindow::checkClientUpdatesFinished, whose Release * parameter made moc 6.4 instantiate the metatype. GameReplay turned out to be a protobuf message, so Release likewise needed release_channel.h in the three headers declaring those signals: window_main.h, dlg_update.h and client_update_checker.h. - moc 6.4 also needs sizeof(QMenu) for the QList<QMenu *> carried by TabSupervisor::setMenu and MainWindow::updateTabMenu. Verified by regenerating moc output with the Debian moc 6.4.2 for all 434 Q_OBJECT/Q_GADGET classes and compiling it, plus recompiling all 1612 source TUs, against the Qt 6.4.2 headers: no remaining failures. --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-10-08 11:13:50 +02:00
BruebachL	b1f4d1e99d	[UI] Flip tear-off menus default to off (#7449) ... Detach menus no longer default to tear-off; users can re-enable in settings. Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-10-08 10:51:03 +02:00
BruebachL	9eafd90a91	[Game] Playmats (#7101) ... * [Game] Playmats Took 19 seconds Took 1 minute * [Playmats] Add fixed override and configurable fallbacks to settings. Took 29 minutes Took 43 seconds * Add main to test. Took 1 minute Took 29 seconds * Move settings to own group Took 11 minutes * Some attempts to refresh macOS compositor Took 2 minutes * Try something else Took 17 minutes * Don't manipulate live list Took 11 minutes * Change things about resolution, address comments. Took 45 minutes Took 12 minutes * Comments. Took 14 minutes Took 8 seconds * Re-order settings menu location Took 2 minutes * Rename PlaymatResolution to Info and add enums Took 8 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-21 10:40:49 +02:00
BruebachL	d99798111e	[UserList] Unify friends/online/ignored list with section dividers and add search bar. (#7119) ... * [UserList] Unify friends/online/ignored list with section dividers and add search bar. Took 31 minutes Took 7 seconds * [UserList] Add a light mode theme Took 12 minutes Took 11 seconds Took 5 minutes Took 2 minutes * [UserList] Re-sort when a user's online state changes setUserOnline() flipped the online flag but never re-sorted, so a buddy who went offline kept the position they had while online and stayed at the top of the list. Re-sort (and re-apply the filter) whenever the flag actually changes, mirroring processUserInfo(). Took 10 minutes * [UserList] Show users in every section they belong to The sectioned list used one row per user with a priority rule (ignored > buddy > online), so an online buddy only appeared under "Buddies" and never in the "Online" list. Sections are now pure membership views: a user gets one row per section they belong to, so an online buddy appears under both "Online" and "Buddies". - Track rows per (section, user) in sectionUsers instead of reparenting a single row; the name->primary-row map is kept for external lookups. - Rebuild, presence and buddy/ignore mutations create/drop rows per section instead of moving a single row between sections. - Dropping one membership no longer removes the user from the other sections. * [UserList] Keyboard navigation for section dividers, popup on selection Section dividers were not selectable, so arrow-key navigation skipped them entirely, and the user popup only appeared on hover or click. Now: - Dividers are selectable, so Up/Down navigation lands on them; they act as collapsible headers once focused (Enter/Space toggle, Left/Right collapse/expand per tree convention), with a focus indicator drawn by the existing delegate. - The popup follows keyboard selection via currentItemChanged, exactly like mouse hover, and closes when the selection moves to a divider or leaves the list. - The popup anchors on the hovered/selected row instead of a user-name lookup, so with duplicate rows (online + buddy) it stays attached to the row under the mouse/cursor. - Left-arrow now actually collapses an expanded section divider: the collapse branch hardcoded the target expansion state to 'expanded', making the key a no-op. - The user popup no longer flashes through a fade when hopping between users (hover or arrow-key navigation): a content swap keeps it opaque, and pending show/hide timers are cancelled so an armed hover timer cannot override a keyboard-selected row or a pending hide kill the newly shown popup. - Bulk rebuild defers per-row divider-count updates to endBulkLoad(), removing the quadratic recount during large online-list loads. - handleOnlineChangeLeft/handleListRemove skip the sort+filter+repaint when nothing actually changed. * [UserList] Tune the role row gradient colors (dark parity, light mode) Dark mode is byte-for-byte the pre-branch painter profile, with the original saturated-left to navy-right fade restored verbatim. Light mode uses the same language at high tint strength: role rows get colored fades (0.75/0.65 left to 0.18/0.10 right), and regular users get flat warm paper cards (AlternateBase) instead of the grey slate. * [UserList] Deselect the list and close the popup on outside clicks Clicking anywhere outside the tree, the popup or an open menu now clears the selection and hides the popup, so a pinned popup does not stay open when the list loses focus. - The application-wide event filter watches every mouse press and treats a press as inside the list UI only when its target is the tree, the popup or an open menu (parent-chain walk), so a click on another list, a tab or the window background deselects. - A hover popup now also closes when the cursor leaves the hovered row. The hide timer previously checked whether the cursor was over the tree, which is always true over empty list space and section dividers, so the popup stayed open after moving off the user. - Deselection keeps the current item so keyboard navigation is not disturbed, and the pinned flag is dropped before hiding so the selection-changed handler does not hide twice. Took 15 minutes * [UserList] Use an enum for the list sections The section identifiers were stringly-typed: eleven hardcoded QStringLiteral comparisons scattered through user_list_widget.cpp, and the display path (sectionTitle) maps every id through tr() anyway, so the raw strings were never shown. A typo compiled fine and silently broke a section. - enum class Section { Buddy, Online, Ignore } replaces the section strings across the sectioned-list API (setSectioned, getSectionIds, setSectionExpanded, the sectionExpanded signal and all membership helpers), giving compile-time checks at every call site. - sectionTitle becomes a switch over the enum and the dead raw-string fallback is gone. - The expanded-section state persists the same stable keys via the panel widget boundary, so existing settings files survive unchanged. - The divider reverse lookup in handleSectionExpansion no longer relies on an empty-string sentinel from QMap::key; it scans the three dividers and bails when the item is not one of them. Took 12 minutes # Commit time for manual adjustment: # Took 2 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-15 22:53:13 +02:00
BruebachL	9d26e07165	[Game] Animate life counter manipulation (#7100) ... * Add animations toggles for the life counter and battlefield Per-effect toggles plus Enable/Disable-all buttons: a life-counter flash on loss and a crimson battlefield shimmer on damage. Took 24 seconds * Animate life changes with a counter flash and battlefield shimmer - Life loss/gain pulses the player life counter with a brief flash - The battlefield table zone shimmers crimson on damage - Respects the per-effect animation toggles Both effects drive their decay from GameScene's shared animation timer through the IAnimatedItem interface (QElapsedTimer based), instead of owning per-item QTimers. Took 8 minutes * Revert unintentional cherry picks Took 2 minutes * Lambda to re-use path calculation. Took 8 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-13 19:12:12 +02:00
RickyRister	c08dc780a7	[Replay] Implement option to skip empty sections (#7069) ... * add settings * [Replay] Implement option to skip empty sections * correct starting offset	2026-08-08 23:12:10 -07:00
BruebachL	adf574e038	[Settings] Shuffle some settings around (#7084) ... * [Settings] Shuffle some settings around Took 21 minutes Took 1 hour 25 minutes * [Settings] Camel case everything * Revert debug schema change * Add new classes * Fix card counters writing to global * Fix CI tests * Fix Windows CI * interface() is a protected keyword for MSVC Took 5 minutes Took 5 seconds * [Settings] Keep menu settings on the appearance settings page Leave the 'Menu settings' group box on the appearance settings page for now; relocating it to the user interface settings page will be done in a separate PR. Took 6 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-08-08 22:27:41 +02:00
BruebachL	12f0f59453	[Settings] Split cache_settings monolith into multiple SettingsManager sub-classes (#7050) ... * [Settings] Split cache_settings into multiple files Took 9 minutes Took 4 minutes * [Settings] Fwd declare settings classes in cache_settings Took 15 minutes * Fix oracle includes. Took 8 minutes * Address comments, fix windows CI Took 8 minutes * fix copy constructor visibility Took 3 minutes * lint Took 2 minutes * Fix native format tests. Took 5 minutes * Remove test header guard Took 4 seconds * Remove tests invalid in CI environ Took 24 seconds * Adjust to rebase. Took 11 minutes * Change settings file name. Took 8 minutes --------- Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de> Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-07-27 11:25:39 +02:00