RickyRister
0da2ac4087
[TabDeckEditor] Refactor: pass nullable deck model into filter widget ( #6969 )
2026-06-05 09:21:28 -07:00
RickyRister
29cc622ce3
[TabDeckEditor] Refactor: Create shared CardDatabaseModel for tab ( #6968 )
2026-06-05 09:21:13 -07:00
RickyRister
86256602ff
[TabDeckEditor] Refactor to use signal instead of calling tab ( #6965 )
...
* [TabDeckEditor] Refactor to use signal instead of calling tab
* update docs
* fix cardInfoRequest
2026-06-03 10:41:55 -07:00
RickyRister
f37c418865
[TabDeckEditor] Refactor: Remove cardDatabase field from analysis interfaces ( #6963 )
...
* [TabDeckEditor] Refactor: Remove cardDatabase field from analysis interfaces
* update includes
2026-06-03 10:08:57 -07:00
RickyRister
46d3b820db
[TabDeckEditor] Refactor: pull up showPrintingSelector ( #6964 )
...
* [TabDeckEditor] Refactor: pull up showPrintingSelector
* trailing newline
2026-06-03 09:35:48 -07:00
RickyRister
e0cbb7f06c
[TabDeckEditor] Refactor: pass ExactCard in signal instead of widget ( #6962 )
...
* [TabDeckEditor] Refactor: pass ExactCard in signal instead of widget
* address comments
2026-06-02 21:22:06 -07:00
RickyRister
f52dc6dda8
[TabDeckEditor] Refactor: consolidate add/decrement card signals ( #6961 )
2026-06-02 20:13:39 -07:00
RickyRister
3fa377a11c
[TabDeckEditor] Refactor check ctrl to be on click ( #6956 )
2026-05-31 03:44:40 -07:00
RickyRister
c5372a9e92
[DeckEditor] Refactor: clean up addCardHelper ( #6939 )
...
* [DeckEditor] Refactor: clean up addCardHelper
* remove setSaveStatus
2026-05-31 03:14:21 -07:00
RickyRister
43c3bf5966
[Game][Arrow] Refactor: Rename arrow methods in GameScene ( #6949 )
...
* [Game][Arrow] Rename methods in GameScene
* move stuff around and docs
2026-05-28 02:32:40 -07:00
RickyRister
1d5d3f2d38
Run formatter on all our files ( #6942 )
2026-05-26 15:11:38 -07:00
BruebachL
b3c89167c5
[Game][Arrows] Hook up to the state zone change properly. ( #6937 )
...
Took 17 minutes
Took 3 seconds
Took 2 minutes
Took 10 minutes
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-05-25 08:19:27 +02:00
BruebachL
90ab663212
[Server][Game][Arrows] Properly notify clients when deleting arrows on card move and transform into ( #6936 )
...
* [Server][Game][Arrows] Properly notify clients when deleting arrows on card move and transform into
Took 15 minutes
* Observe "not found" response
Took 18 minutes
Took 4 seconds
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-05-25 08:19:17 +02:00
RickyRister
8004d4f2d4
[VDE] Disable filter dock widget ( #6924 )
2026-05-22 03:26:52 -07:00
DawnFire42
33e0f8699b
Standardize Doxygen documentation ( #6885 )
2026-05-21 22:58:07 +02:00
BruebachL
491d1c9187
[Game][Arrows] Split Arrows into ArrowData and ArrowItem ( #6918 )
...
* [Game][Arrows] Split Arrows into ArrowData and ArrowItem
Took 13 minutes
Took 5 seconds
Took 1 minute
Took 26 seconds
* Address comments.
Took 17 minutes
Took 9 seconds
Took 1 minute
* Change check.
Took 3 minutes
* Pass by const reference.
Took 10 minutes
* Remove extra method
Took 2 minutes
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-05-21 20:31:14 +02:00
BruebachL
5219cffa6b
[Player] Rename player to player logic ( #6913 )
...
Took 13 minutes
Took 6 seconds
Took 2 minutes
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-05-19 12:36:31 +02:00
DawnFire42
aadee34238
style: Add braces to all control flow statements ( #6887 )
...
* style: Add braces to all control flow statements
Standardize code style by adding explicit braces to all single-statement
control flow blocks (if, else, for, while) across the entire codebase.
Also documents the InsertBraces clang-format option (requires v15+) for
future automated enforcement.
* InsertBraces-check-enabled
2026-05-16 19:19:53 +02:00
RickyRister
d18f3bce47
[VisualDatabaseDisplayWidget] Refactor: Make all fields private ( #6875 )
2026-05-11 20:23:29 -07:00
RickyRister
b66743c83c
[DeckEditor] Refactor searchEdit highlighting after add card ( #6874 )
...
* [DeckEditor] Refactor searchEdit highlighting after add card
* make searchEdit private
2026-05-11 20:23:12 -07:00
BruebachL
314a577807
Do not allow users to remove VDE functionality by closing tabs ( #6838 )
...
* Do not allow users to remove VDE functionality by closing tabs.
Took 6 minutes
* Set filter toolbar visible on delayed initialization.
Took 5 minutes
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-04-29 12:37:47 +02:00
BruebachL
9226bc9ddd
[TabArchidekt] Place sideboard categories into the sideboard. ( #6824 )
...
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 11 (push) Blocked by required conditions
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Fedora 42 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 11 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 22.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
Took 35 minutes
Took 3 seconds
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-04-21 08:09:39 +02:00
ebbit1q
501c4b96d4
clear all players when closing game tab ( #6828 )
...
this prevents issues caused by items in play when using the player
destructor in the wrong order
2026-04-21 08:09:20 +02:00
BruebachL
832f70496a
[EDHRec] Fix unintentional navigation on card right click ( #6814 )
...
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 11 (push) Blocked by required conditions
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Fedora 42 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 11 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 22.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
Don't double emit cardClicked and also pass along the mouseEvent so we can check if it's a left or right click.
Took 26 minutes
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-04-15 14:14:30 +02:00
ebbit1q
3ec9ae9772
fix compiling on arch ( #6768 )
...
Build Desktop / Configure (push) Has been cancelled
Build Docker Image / amd64 & arm64 (push) Has been cancelled
Build Desktop / Debian 11 (push) Has been cancelled
Build Desktop / Debian 13 (push) Has been cancelled
Build Desktop / Debian 12 (push) Has been cancelled
Build Desktop / Fedora 43 (push) Has been cancelled
Build Desktop / Fedora 42 (push) Has been cancelled
Build Desktop / Servatrice_Debian 11 (push) Has been cancelled
Build Desktop / Ubuntu 24.04 (push) Has been cancelled
Build Desktop / Ubuntu 26.04 (push) Has been cancelled
Build Desktop / Ubuntu 22.04 (push) Has been cancelled
Build Desktop / Arch (push) Has been cancelled
Build Desktop / macOS 14 (push) Has been cancelled
Build Desktop / macOS 15 (push) Has been cancelled
Build Desktop / macOS 13 Intel (push) Has been cancelled
Build Desktop / macOS 15 Debug (push) Has been cancelled
Build Desktop / Windows 10 (push) Has been cancelled
* fix compiling on arch
* redo all the logging in affected files
2026-04-05 21:52:46 +02:00
ebbit1q
69c046cca4
remove all separate storing of widget sizes, rely on geometry ( #6712 )
2026-03-16 23:38:47 +01:00
RickyRister
dead993639
[DeckList] Refactor load from plaintext to take normalizer as param ( #6664 )
...
* [DeckList] Refactor load from plaintext to take normalizer as param
* update usages
* weaken unit test
* weaken unit test more
* revert unit test
* move CardNameNormalizer to libcockatrice_card
* update unit test
* formatting
2026-03-06 10:39:04 -08:00
RickyRister
a90997353b
[TabGame] Fix concede removing player without waiting for server ( #6622 )
2026-02-23 01:33:08 +01:00
RickyRister
bdb42bbbbd
[VDE] Separate layout settings for visual deck editor ( #6595 )
2026-02-08 13:37:56 -08:00
RickyRister
ac7ff3a0e9
[LayoutSettings] Refactor how widgetSize settings are managed ( #6594 )
2026-02-08 05:07:53 -08:00
RickyRister
1eb6027443
clean up freeDocksSize in tabs with dockWidgets ( #6593 )
2026-02-08 05:07:40 -08:00
RickyRister
edc8691731
[LayoutSettings] Don't return by const value ( #6592 )
...
* [LayoutSettings] Don't return by const value
* fix compile failure
2026-02-07 20:42:23 -08:00
BruebachL
ffc55aff10
[VDE] Add shortcut to increment cards [Alt + LMB] ( #6555 )
...
Took 13 minutes
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-01-24 11:28:06 +01:00
BruebachL
12b5525a2d
[TabArchidekt] Cleaner filters, infinite scrolling, and a "go back button" ( #6545 )
...
* [TabArchidekt] Cleaner filters, infinite scrolling, and a "go back button"
Took 46 minutes
Took 5 seconds
* Fix infinite scroll triggering in detail view.
Took 25 minutes
Took 3 seconds
* Use setLabelText() so it's white
Took 2 minutes
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-01-24 11:21:12 +01:00
RickyRister
3c48d92663
[DeckEditor] Show info in PrintingSelector dock when override printings enabled ( #6554 )
...
* don't hide printing selector dock
* extract warning message to separate file
* create printing disabled info widget
2026-01-24 02:20:16 -08:00
RickyRister
9c07c7a963
[TabGame] Automatically sync view menu actions ( #6529 )
2026-01-16 17:22:48 -08:00
RickyRister
d579c82cb9
[DeckLoader] Make save/load methods static ( #6476 )
...
* const
* [DeckLoader] make methods static
* use static methods
* add docs
* add docs
2026-01-16 13:20:36 -05:00
RickyRister
c7c7bf550a
[TabGame] Don't create replay dock if not replay tab ( #6527 )
...
* [TabGame] Don't create replay dock if not replay tab
* use replayDock to determine if replay tab
* null check replayManager in dtor
2026-01-16 09:45:10 -08:00
RickyRister
84483c56d7
[TabDeckEditor] Generalize visibility filter and extract it to a separate file ( #6526 )
...
* create class
* use new class in old code
2026-01-16 10:12:46 -05:00
RickyRister
154b9ace92
[TabDeckEditor] Move cardDatabase dock action to top of menu ( #6523 )
2026-01-16 10:10:36 -05:00
RickyRister
93f0715d02
[TabDeckEditor] Save cardDatabase dock size in settings ( #6524 )
2026-01-15 21:54:50 -05:00
RickyRister
57e6c91689
[TabDeckEditor] Automatically sync view menu actions ( #6522 )
2026-01-15 21:05:19 -05:00
RickyRister
c553e15036
[TabDeckEditor] Fix bug in #6499 causing view menu actions to sometimes not work ( #6518 )
...
* remove a special case
* fix
2026-01-14 14:20:12 +01:00
RickyRister
b19312be70
[TabDeckEditor] Consolidate dockWidget management ( #6499 )
2026-01-14 09:48:26 +01:00
RickyRister
ee2699413c
[TabDeckEditor] Make card database a dock widget ( #6472 )
...
* [TabDeckEditor] Make card database a dock widget
* delete eventFilter implementation in abstract
2026-01-05 00:06:22 -08:00
BruebachL
df9a8b2272
[VDE] Deck Analytics Widgets overhaul ( #6463 )
...
* [VDE] Deck Analytics Widgets overhaul
Took 2 minutes
Took 3 minutes
Took 3 minutes
* Qt5 version guards.
Took 33 minutes
Took 3 seconds
* Include QtMath
Took 3 minutes
Took 8 seconds
* Use getCards()
Took 4 minutes
* Non pointer stuff
Took 52 seconds
* Add a newline to the tooltip
Took 2 minutes
Took 27 seconds
* Fix build failure on macOS 15
* Rename some things.
Took 17 minutes
Took 11 seconds
Took 18 seconds
* Address overloads, fix default configuration.
Took 1 hour 9 minutes
Took 8 seconds
* Fix mana curve default config.
Took 4 minutes
* Namespace to Qt libs
Took 5 minutes
* Selection overlay is transparent for mouse events.
Took 2 minutes
* Brace initialize.
Took 8 minutes
* Debian 11.
Took 5 minutes
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
Co-authored-by: RickyRister <ricky.rister.wang@gmail.com>
2025-12-31 19:45:49 +01:00
RickyRister
b2dd8eed3f
[TabDeckEditor] Create class to centralize deck state ( #6459 )
...
* create new file
* use QSharedPointer in DeckListModel
* [TabDeckEditor] Create class to centralize deck state
* delete method
* update docs
2025-12-31 17:54:47 +01:00
RickyRister
96c82a0377
[Refactor] Clean up some PrintingSelector widgets ( #6451 )
...
* remove currentZone from PrintingSelector
* don't store constructor args in fields if they're just passed
* simplify some methods
* refactor
* clean up initializeFormats
* more refactoring in CardAmountWidget
2025-12-29 12:03:44 +01:00
RickyRister
70f9982c29
Bump minimum Qt version from 5.8 to 5.15 ( #6442 )
...
* Bump minimum Qt version from 5.8 to 5.15
* remove version check
* remove version checks
2025-12-23 09:58:23 -08:00
BruebachL
e7af1bbec9
[EDHRec] New layout for commander details ( #6405 )
...
* Stuff
Took 22 minutes
* New layout for commander details.
Took 1 hour 18 minutes
* Update plate to encompass everything, update font sizes.
Took 10 minutes
* Include map.
Took 2 minutes
* Include QSet
Took 5 minutes
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2025-12-23 16:00:07 +01:00
