6106 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
DawnFire42	6fd4bbaab1	Added command zone test	2026-06-30 12:12:56 -04:00
DawnFire42	d93a8d7f7e	comment fix	2026-06-30 10:59:53 -04:00
DawnFire42	a11e70efb3	Added shortcuts registration with empty default	2026-06-30 10:18:47 -04:00
DawnFire42	04f18aa0c8	rebase fix	2026-06-30 09:59:22 -04:00
DawnFire42	bc09a19b50	Wire command zone menu, harden counter command handling, and expand tests ... - Connect aMoveToCommandZone to cmMoveToCommandZone; the menu item was added, shown, and shortcut-bound but never wired, so it did nothing - Extract evaluateModifyCounter() and route cmdIncCounter/cmdSetCounter through it, replacing isCommandZoneCounterBlocked; reject inc/set on an inactive tax counter so a hidden counter cannot accumulate value - Reject reserved tax counter names in cmdCreateCounter to prevent a client from spoofing a system tax counter via a user-created counter - Route AbstractCounter::valueChanged through the virtual setValue() so CommanderTaxCounter clamps and refreshes its tooltip on value changes - Deduplicate actPlayAndIncreaseTax/actPlayAndIncreasePartnerTax into a single playAndIncreaseTax(counterId) helper - Move MINIMUM_STACKING_HEIGHT from CommandZone to the PlayerGraphicsItem layout code, its only consumer - Remove unused AbstractCounter forward declaration from player_logic.h - Add EvaluateModifyCounter tests and PartnerTax cases for evaluateSetCounterActive - Pin the FirstUserId floor in new_counter_id_test using ids 3 and 5 so a naive "highest id + 1" regression fails the test	2026-06-30 09:30:29 -04:00
DawnFire42	0bfb0f4131	fix clamping	2026-06-30 09:30:29 -04:00
DawnFire42	f74f83c5ec	Sync command zone visibility on construction and reflow stack on height change ... - Sync command zone visibility in the PlayerGraphicsItem constructor in case processPlayerInfo runs before the signal is connected. - Emit CommandZone::effectiveHeightChanged() when a minimized zone's height changes so the stack zone repositions.	2026-06-30 09:30:28 -04:00
DawnFire42	4c60fd2ebd	Hide 'increase tax' play actions on multi-card selection	2026-06-30 09:30:28 -04:00
DawnFire42	25e2633ee7	Reconcile tax counter visibility ownership and harden tax log formatting ... - Make AbstractCounter::setActive() the sole owner of counter visibility; document the contract. - Drop the redundant setVisible() from CommandZone::rearrangeTaxCounters(); it now only lays out by isActive(). - Format tax log lines with a single atomic 4-arg arg() instead of mixing string and int overloads.	2026-06-30 09:30:28 -04:00
DawnFire42	3fb3a329ef	Prefix shadowed CounterState constructor args with underscores	2026-06-30 09:30:27 -04:00
DawnFire42	2c77509ad3	Extract counter command authorization into testable helpers ... Pull the pure guard logic out of cmdDelCounter and cmdSetCounterActive into static evaluateDelCounter/evaluateSetCounterActive methods, leaving the handlers as thin shells over the decision. Add command_zone_tests covering every authorization branch of both evaluators.	2026-06-30 09:30:27 -04:00
DawnFire42	eefdb6a6f0	Harden command zone tax counter handling and more clean up ... - Initialize commandZoneGraphicsItem to nullptr so the pervasive null checks have defined behavior before initializeZones() runs - Remove unused getTaxCounterWidgets() - Enforce the "reset tax to 0 before deactivating" invariant server-side in cmdSetCounterActive, not just in the UI - Hide tax increment/decrement menu actions at their bounds (0 and MAX_COUNTER_VALUE) to avoid sending no-op commands - Drop redundant/inconsistent toggle labels from CommandZoneMenu:: retranslateUi(); updateTaxCounterActionStates() owns them - Add default=-1 to Event_SetCounterActive.counter_id for parity with Command_SetCounterActive	2026-06-30 09:30:26 -04:00
DawnFire42	01399b3dfc	Add test coverage for setActive change-detection behavior	2026-06-30 09:30:26 -04:00
DawnFire42	1fd5335754	Add default=true to Event_SetCounterActive.active for consistency with command	2026-06-30 09:30:26 -04:00
DawnFire42	66ce8f1684	Resolve PlayerActions at call time instead of capturing at construction	2026-06-30 09:30:25 -04:00
DawnFire42	6a9c7efcca	Fix command zone menu showing Minimize even when zone is already minimized	2026-06-30 09:30:25 -04:00
DawnFire42	e9e02c51c8	Prevent user counter IDs from colliding with reserved range ... In non-Commander games, newCounterId() could return 8 or 9, colliding with reserved commander tax counter IDs. A malicious client could exploit this via cmd_set_counter_active. Now user counters always start at ID 10+.	2026-06-30 09:30:25 -04:00
DawnFire42	f233d87d6d	Restrict cmdSetCounterActive to tax counters only	2026-06-30 09:30:24 -04:00
DawnFire42	db26191f2c	Code cleanup ... - Add missing isCommandZoneCounterBlocked check to cmdSetCounterActive - Revert accidental deck view layout change from b4057a86 - Fix duplicate @param in playSelectedCardsImpl doc - Add null check for PlayerLogic in CommandZoneMenu constructor - Add index bounds check in CommandZone handleDropEvent - Add index bounds check in StackZone handleDropEvent - Add ownership comment for tax counter widget creation - Add command zone to zoneGraphicsItems map - Conditionally show command zone menu item based on server support - Remove layer-violating includes from player_logic.cpp - Fix tax counter increment (1 per cast, not 2) - Add getTaxCounterIfActive() helper to PlayerGraphicsItem	2026-06-30 09:30:24 -04:00
DawnFire42	928b0a1483	Fix Command Zone graphics/logic layers separation ... 1. CommandZoneMenu: Changed to take PlayerGraphicsItem* instead of PlayerLogic*, accessing logic via player->getLogic() 2. Removed getCounterWidget() from PlayerLogic; method already exists correctly in PlayerGraphicsItem 3. PlayerMenu: CommandZoneMenu, fixed signal connection to use player->getLogic() for commandZoneSupportChanged 4. AbstractCounter: Connects to CounterState::activeChanged signal, removing direct graphics calls from PlayerEventHandler 5. CommandZone: Explicit tax counter registration via registerTaxCounter() with auto-cleanup, replacing childItems()/dynamic_cast iteration Also fixed PlayerActions to query CounterState instead of AbstractCounter for proper layer separation.	2026-06-30 09:30:23 -04:00
Lukas Brübach	cbee3726c9	Adjust to rebase. ... Took 28 minutes Took 7 seconds Took 2 minutes Took 8 minutes Took 13 seconds	2026-06-30 09:30:23 -04:00
DawnFire42	b4adb20a5f	[Game] Add Command Zone support with commander tax tracking ... - Add CommandZone and CommandZoneLogic for commander - Add CommanderTaxCounter - Add counter active state protocol (show/hide tax counters) - Add "Enable Command Zone" option in game creation dialogs - Add context menu actions for command zone operations Took 9 minutes Took 11 minutes	2026-06-30 09:30:13 -04:00
DawnFire42	18b23b19a7	Split trice_limits.h into dedicated headers (#7025) ... * Split trice_limits.h into dedicated headers * Updated docstrings	2026-06-29 14:37:52 -07:00
DawnFire42	4a384f2a75	fix theme manager return type warning (#7026)	2026-06-29 08:03:30 -07:00
DawnFire42	05ae6f47a6	Unify counter clamp arithmetic into shared addClamped() helper (#7009) ... * Unify counter clamp arithmetic into shared addClamped() helper - Add addClamped() in new header clamped_arithmetic.h; uses a 64-bit intermediate so the addition cannot overflow int. - Use it in Server_Card::incrementCounter() (clamps [0, MAX_COUNTERS_ON_CARD]) and Server_Counter::incrementCount() (clamps [INT_MIN, INT_MAX]), removing the duplicated overflow-safe logic and its keep-in-sync TODO. - Inline incrementCount() into server_counter.h; server_counter.cpp now holds only the constructor and getInfo(). - Clarify the card-counter bounds comment in trice_limits.h. * Rename MAX_COUNTERS_ON_CARD to MAX_COUNTER_VALUE The constant caps the counter's value, not how many counters can be on the card * Add direct unit tests for addClamped() helper * Harden offsetCardCounter() against signed-int overflow Replace the raw oldValue + offset sum with addClamped(), clamping to [0, MAX_COUNTER_VALUE] without overflow. * Comment update * Remove class names from addClamped() docstring	2026-06-28 16:10:57 -07:00
RickyRister	fcac7493ad	[Card] Add facedown property to CardRelation (#6997) ... * [Card] Add facedown property to CardRelation * trailing newline * fix comments * update schema	2026-06-28 02:03:07 -07:00
DawnFire42	055ba9a16f	Add subtype breakdown counter for card selection (#6923) ... * Add subtype breakdown counter for card selection Display a categorized count of creature subtypes (and other card type subtypes) when multiple cards are selected. The breakdown appears above the total selection counter in the bottom-right corner. Subtypes are grouped by main card type and sorted by frequency, with the most common subtypes positioned adjacent to the total count for quick reference. The feature can be toggled via a new checkbox in Settings > User Interface. * Alignment fix * Computation logic moved to helper funtction in separate file * Rename SubtypeCounter to SubtypeTally * Fix subtype tally alignment by using grid layout instead of character padding * Rename count to tally in the subtype breakdown feature * partial rename * list position fixed * Clean up code and documentation * Rename subtypeCountLabelStyle to subtypeTallyLabelStyle and fix include ordering * Fix include path for selection_subtype_tally.h after file relocation * fixed count to tally rename inconsistencies	2026-06-27 15:53:21 -07:00
BruebachL	ad4922537d	[UserListDelegate] Supply providerid in cmd, position popup correctly (#7020) ... * [UserListDelegate] Transmit providerId in cmd when setting user banner card * [UserListDelegate] Position popup correctly * Lint. --------- Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de>	2026-06-27 14:44:24 -04:00
dependabot[bot]	4cbc00b9c4	Bump actions/cache from 5 to 6 (#7019)	2026-06-27 17:25:30 +02:00
BruebachL	6dc974a05d	[UserListDelegate] Consider providerId (#7018) ... Co-authored-by: Lukas Brübach <lukas.bruebach@bdosecurity.de>	2026-06-27 11:23:55 -04:00
BruebachL	2914874720	[Room][UserList] Introduce style delegate (#6981) ... * [Room] Additionally show a tab for friends and ignored users instead of just all online users. Took 21 minutes Took 12 minutes * [Room][UserList] Introduce style delegate for user list - Allow users to set a card name and parameters as their background banner - Allow mods to white/blacklist cards - Allow toggling back to the old display style Took 7 minutes Took 28 seconds Took 2 minutes Took 2 minutes * Right checkstate. Took 14 minutes Took 2 minutes * Utility for test. Took 9 minutes Took 8 seconds Took 2 seconds * Lint. Took 10 minutes * Algorithm for sql schema migration Took 13 minutes * Use {prefix}, bound card name, return errors. Took 27 seconds * Convert queue to while loop. Took 19 seconds * Hover popup. Took 36 minutes Took 1 minute * More granular signals, popup for user info. Took 25 minutes Took 8 seconds Took 16 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-26 20:52:24 -04:00
tooomm	c9ebdb451f	CI: Avoid failing tx step if secret can not be accessed (#7012)	2026-06-26 16:39:33 +02:00
Zach H	80426d77bc	Add Discord account registration monitor (#7013) ... A read-only cron script that posts new Servatrice account registrations to a Discord channel via webhook. Dedups by an auto-increment id high-water-mark (single-integer state, no duplicates, nothing missed across downtime). Reads DB credentials and the webhook from a servatrice-style ini via --config.	2026-06-21 01:09:57 -04:00
Phred Lane	e99a55ccab	CI: Simplified build workflow (#6995) ... * simplified build workflow * cleaned up translation workflows * fixed typo * updated format based on code review Co-authored-by: tooomm <tooomm@users.noreply.github.com> * restored quotes around `group` string --------- Co-authored-by: tooomm <tooomm@users.noreply.github.com>	2026-06-20 22:44:37 +02:00
dependabot[bot]	2a3c4a2455	Bump actions/checkout from 6 to 7 (#7011)	2026-06-20 19:11:10 +02:00
Phred Lane	687e6644bc	replaced dynamically injected variables with environment variables (#6996) ... This prevents some injection attacks and makes all the scripts valid Bash.	2026-06-19 16:42:15 +02:00
transifex-integration[bot]	e28f31c93e	Translate oracle/oracle_en@source.ts in es (#7006)	2026-06-17 22:16:26 +02:00
DawnFire42	0c140d866f	[Card] Respect disabled sets when loading v3 card databases (#6882) (#7004)	2026-06-17 14:09:05 +02:00
RickyRister	45d0cedb5c	[Game] Setting to restore old chat autofocus behavior (#6992) ... * [Game] Setting to restore old chat autofocus behavior * fixes	2026-06-15 17:04:30 +02:00
BruebachL	309e4730a3	[Lobby][DeckView] Always at minimum create main and side deck zone containers. (#7001) ... Took 12 minutes Took 3 seconds Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-15 15:50:04 +02:00
BruebachL	0c4cc3f824	[DeckView][DeckEditor] Implement shortcut for load deck from website (default: Ctrl+Shift+O) (#7002) ... Took 12 minutes Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-15 15:49:47 +02:00
BruebachL	dfbe944c31	[App][Windows][NSIS] Use QProcess::setNativeArguments on Windows, properly order portable detection (#6989) ... Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-15 15:23:18 +02:00
RickyRister	0f3e6fbe26	[CardDatabase] Pass CardInfoPtr by const ref (#6998) ... * [CardDatabase] Pass CardInfoPtr by const ref * trailing newline	2026-06-14 04:46:18 -07:00
RickyRister	5ffe344779	[Game] Fix facedown predefined tokens leaking tablerow (#7000)	2026-06-14 03:21:17 -07:00
kongwu	f28ede7ae3	[UserContextMenu] Add confirmation dialog before kicking a player (#6987)	2026-06-13 02:42:55 -07:00
BruebachL	7aaacbf347	[Update][NSIS] Use single string shell invocation (#6986) ... Took 18 minutes Took 2 minutes Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-11 21:17:28 +02:00
tooomm	694adc9e64	Use Visual Studio 2026 (#6985)	2026-06-11 10:45:17 +02:00
BruebachL	b17d879da8	[Game][Graphics][Player] Add named zone lookup-map to player graphics. (#6984) ... Took 16 minutes Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>	2026-06-10 10:58:28 +02:00
ebbit1q	6be9cec6e2	do not save a const reference to the user data in the info dialog (#6974) ... * do not save a const reference to the user data in the info dialog * cmake format	2026-06-09 23:35:00 -07:00
kongwu	6d0a423dcf	[Messages] Add option to ignore private messages from non-buddy users (#6966) ... * [Messages] Add option to ignore private messages from non-buddy users * [Messages] Exclude Moderator/Admin from non-buddy ignore filter Moderator and Admin messages should not be filtered out when the 'Ignore private messages from non-buddies' setting is enabled, to ensure that important warnings from server staff reach users.	2026-06-09 20:49:29 -07:00