mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-08 11:03:25 -08:00
17f583013b
* Parent card menu submenus to the menu that owns them QMenu::addMenu(QMenu *) does not take ownership of the submenu, and these submenus were created without a parent. Since CardMenu is rebuilt from scratch on every right-click, each rebuild leaked the MoveMenu, PtMenu, card counters and related-cards submenus. Pass the owning CardMenu as the QWidget parent so Qt's parent-child mechanism frees them with it. * Delete the replaced card menu in TabGame to fix menu rebuild leak PlayerMenu creates a new CardMenu on every right-click and TabGame installs it with QAction::setMenu(), which does not take ownership, so the previous menu was never freed. TabGame now deletes the menu it replaces and reuses a single empty placeholder menu instead of allocating one per update. The installed menu is also released when the tab is destroyed.
95 lines
No EOL
4.1 KiB
C++
95 lines
No EOL
4.1 KiB
C++
#include "pt_menu.h"
|
|
|
|
#include "../../../client/settings/cache_settings.h"
|
|
#include "../../../client/settings/shortcuts_settings.h"
|
|
#include "../../game_scene.h"
|
|
#include "../player_graphics_item.h"
|
|
|
|
#include <QAction>
|
|
#include <libcockatrice/game/player/player_actions.h>
|
|
#include <libcockatrice/game/player/player_logic.h>
|
|
|
|
PtMenu::PtMenu(PlayerGraphicsItem *player, QWidget *parent) : QMenu(tr("Power / toughness"), parent)
|
|
{
|
|
PlayerActions *playerActions = player->getLogic()->getPlayerActions();
|
|
|
|
aIncP = new QAction(this);
|
|
connect(aIncP, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actIncP(player->getGameScene()->selectedCardStates()); });
|
|
aDecP = new QAction(this);
|
|
connect(aDecP, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actDecP(player->getGameScene()->selectedCardStates()); });
|
|
aIncT = new QAction(this);
|
|
connect(aIncT, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actIncT(player->getGameScene()->selectedCardStates()); });
|
|
aDecT = new QAction(this);
|
|
connect(aDecT, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actDecT(player->getGameScene()->selectedCardStates()); });
|
|
aIncPT = new QAction(this);
|
|
connect(aIncPT, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actIncPT(player->getGameScene()->selectedCardStates()); });
|
|
aDecPT = new QAction(this);
|
|
connect(aDecPT, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actDecPT(player->getGameScene()->selectedCardStates()); });
|
|
aFlowP = new QAction(this);
|
|
connect(aFlowP, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actFlowP(player->getGameScene()->selectedCardStates()); });
|
|
aFlowT = new QAction(this);
|
|
connect(aFlowT, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actFlowT(player->getGameScene()->selectedCardStates()); });
|
|
aSetPT = new QAction(this);
|
|
connect(aSetPT, &QAction::triggered, playerActions, [player, playerActions] {
|
|
playerActions->actRequestSetPTDialog(player->getGameScene()->selectedCardStates());
|
|
});
|
|
aResetPT = new QAction(this);
|
|
connect(aResetPT, &QAction::triggered, playerActions,
|
|
[player, playerActions] { playerActions->actResetPT(player->getGameScene()->selectedCardStates()); });
|
|
|
|
addAction(aIncP);
|
|
addAction(aDecP);
|
|
addAction(aFlowP);
|
|
addSeparator();
|
|
addAction(aIncT);
|
|
addAction(aDecT);
|
|
addAction(aFlowT);
|
|
addSeparator();
|
|
addAction(aIncPT);
|
|
addAction(aDecPT);
|
|
addSeparator();
|
|
addAction(aSetPT);
|
|
addAction(aResetPT);
|
|
|
|
setShortcutsActive();
|
|
|
|
retranslateUi();
|
|
}
|
|
|
|
void PtMenu::retranslateUi()
|
|
{
|
|
aIncP->setText(tr("&Increase power"));
|
|
aDecP->setText(tr("&Decrease power"));
|
|
aIncT->setText(tr("I&ncrease toughness"));
|
|
aDecT->setText(tr("D&ecrease toughness"));
|
|
aIncPT->setText(tr("In&crease power and toughness"));
|
|
aDecPT->setText(tr("Dec&rease power and toughness"));
|
|
aFlowP->setText(tr("Increase power and decrease toughness"));
|
|
aFlowT->setText(tr("Decrease power and increase toughness"));
|
|
aSetPT->setText(tr("Set &power and toughness..."));
|
|
aResetPT->setText(tr("Reset p&ower and toughness"));
|
|
}
|
|
|
|
void PtMenu::setShortcutsActive()
|
|
{
|
|
ShortcutsSettings &shortcuts = SettingsCache::instance().shortcuts();
|
|
|
|
aIncP->setShortcuts(shortcuts.getShortcut("Player/aIncP"));
|
|
aDecP->setShortcuts(shortcuts.getShortcut("Player/aDecP"));
|
|
aIncT->setShortcuts(shortcuts.getShortcut("Player/aIncT"));
|
|
aDecT->setShortcuts(shortcuts.getShortcut("Player/aDecT"));
|
|
aIncPT->setShortcuts(shortcuts.getShortcut("Player/aIncPT"));
|
|
aDecPT->setShortcuts(shortcuts.getShortcut("Player/aDecPT"));
|
|
aFlowP->setShortcuts(shortcuts.getShortcut("Player/aFlowP"));
|
|
aFlowT->setShortcuts(shortcuts.getShortcut("Player/aFlowT"));
|
|
aSetPT->setShortcuts(shortcuts.getShortcut("Player/aSetPT"));
|
|
aResetPT->setShortcuts(shortcuts.getShortcut("Player/aResetPT"));
|
|
} |